Repository navigation
docs: clarify JSON2 type hints, query inference, and ALTER settings - #2916
Conversation
f29833a to
8834348
Compare
|
@codex review |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Preserve the published legacy anchors in the JSON2 documentation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 4
Open (4)
What changed in this PR
Updates Nightly JSON2 documentation in English and Chinese, including syntax, type hints, querying, pipeline options, and ALTER TABLE behavior.
Changes:
- Revised JSON2 usage and configuration guidance.
- Updated pipeline type-hint documentation.
- Added JSON2 configuration alteration references.
| File | Summary |
|---|---|
i18n/zh/docusaurus-plugin-content-docs/current/user-guide/logs/json2.md |
Updated Chinese JSON2 guide. |
i18n/zh/docusaurus-plugin-content-docs/current/reference/sql/alter.md |
Added Chinese JSON2 ALTER documentation. |
i18n/zh/docusaurus-plugin-content-docs/current/reference/pipeline/pipeline-config.md |
Updated Chinese pipeline options. |
docs/user-guide/logs/json2.md |
Updated English JSON2 guide. |
docs/reference/sql/alter.md |
Added English JSON2 ALTER documentation. |
docs/reference/pipeline/pipeline-config.md |
Updated English pipeline options. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MichaelScofield
left a comment
There was a problem hiding this comment.
Reviewed all 6 changed Nightly documentation files (276 additions / 104 deletions), including English/Chinese alignment, links and heading compatibility, and the JSON2 claims against current upstream source and SQLness expectations.
Found one additional P2 technical issue below: explicit json_get calls do not inherit column type hints in the same way as dot syntax.
The existing anchor findings also apply: retain json-field-type-hints in English and 语法, json-字段-type-hint, json_get-udf, and 未来规划 in Chinese. I have not duplicated those inline threads.
Verification: the PR's build and both strict locale link checks are green. This was a source/test-expectation review; I did not rerun the site builds or execute the SQL examples locally. No repository files were changed.
remote unused AnchorAlias
c80c78b to
985c072
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 985c072caf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

What changed
json_getand dot syntax.ALTER TABLE.Scope
Verification
Checklist