Skip to content

[Nonve][fix] reject unsupported DoRA adapters during loading - #22737

Draft
Funatiq wants to merge 1 commit into
NVIDIA:mainfrom
Funatiq:dev/cleanup/dora
Draft

Funatiq wants to merge 1 commit into
NVIDIA:mainfrom
Funatiq:dev/cleanup/dora

Conversation

@Funatiq

@Funatiq Funatiq commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

Description

Reject HF adapters that enable use_dora before reading checkpoint weights. Also reject parsed magnitude vectors on dense layers and MoE experts when the configuration omits or disables use_dora, before querying CUDA or registering adapter state.

Remove unreachable magnitude transfer and packing paths while preserving the native LoRA metadata layout. Replace the FP8-only GPU rejection test with CPU coverage for config-only rejection and dense/MoE magnitude checkpoints in FP16, BF16, and FP8.

@coderabbitai summary

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Reject HF adapters that enable use_dora before reading checkpoint weights. Also reject parsed magnitude vectors on dense layers and MoE experts when the configuration omits or disables use_dora, before querying CUDA or registering adapter state.

Remove unreachable magnitude transfer and packing paths while preserving the native LoRA metadata layout. Replace the FP8-only GPU rejection test with CPU coverage for config-only rejection and dense/MoE magnitude checkpoints in FP16, BF16, and FP8.

Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
@Funatiq

Funatiq commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #86527 [ run ] triggered by Bot. Commit: 9ae9290 Link to invocation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants