Repository navigation
Reg file implementation - #27
Merged
Guardian-Monkey merged 6 commits intoNov 8, 2026
Merged
Conversation
Refactor input declarations and comments for clarity.
Updated the testbench for the register file to include a success message.
Contributor
Author
|
Completed the register file implementation and Level 1 testbench. The automated lint and Level 1 checks are passing. Ready for review. |
Hans1021
requested changes
Nov 2, 2026
Hans1021
left a comment
Hans1021
left a comment
Member
There was a problem hiding this comment.
Looks good overall. Could you also remove reg_file from LINT_SKIP in the Makefile, then make sure CI still passes?
Added LINT_SKIP variable to exclude specific modules from linting.
Contributor
Author
|
Hi Hans, I've removed |
Guardian-Monkey
approved these changes
Nov 8, 2026
Guardian-Monkey
left a comment
Guardian-Monkey
left a comment
Contributor
There was a problem hiding this comment.
reg_file looks good, follows specification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.