Repository navigation
ci: fix vTDS deploy create-github-app-token GitHub Action step. - #77
Merged
Merged
Conversation
synackd
requested changes
Sep 3, 2026
synackd
left a comment
synackd
left a comment
Contributor
There was a problem hiding this comment.
Changes look fine, just need DCO on commit.
Signed-off-by: David Fluck <david.fluck@hpe.com>
davidfluck-hpe
force-pushed
the
fix-vtds-deploy
branch
from
September 3, 2026 22:09
d7d2f38 to
64e575d
Compare
Contributor
Author
|
Gah, I'm sorry, I always get GitHub verified commits mixed up with signed commits heh. Pushed. |
synackd
approved these changes
Sep 3, 2026
synackd
left a comment
synackd
left a comment
Contributor
There was a problem hiding this comment.
LGTM. No worries, it can be confusing.
synackd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changeset fixes a bug where the
create-github-app-tokenGitHub Action step output was not being referenced correctly, leading to subsequent empty token variables, which caused thedeployaction to fail.Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change