Skip to content

Some ASV peakmem benchmarks always show the same "improvement" #1605

Description

@Sevans711

Version

2026.6.0

How did you install UXarray?

Source

What happened?

ASV benchmarking is showing the same improvement (to within ~2%) for these three tests, every single time, regardless of whether the PR should have any effect on them:

Change Before After Ratio Benchmark (Parameter)
- 578M 391M 0.68 face_bounds.FaceBounds.peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/geoflow-small/grid.nc'))
- 708M 390M 0.55 face_bounds.FaceBounds.peakmem_face_bounds(PosixPath('/home/runner/work/uxarray/uxarray/test/meshfiles/ugrid/quad-hexagon/grid.nc'))
- 498M 384M 0.77 mpas_ocean.Gradient.peakmem_gradient('480km')

Examples of where this occurs:

Additionally, there are a few slightly older PRs where the numbers look different by more than a few percent, but still show similar trends as above:

What did you expect to happen?

I expected "Benchmarks that have improved" to reflect actual improvements to relevant parts of the code, or at least, to reflect small deviations which occur when running the benchmarking tests multiple times. Instead, these three benchmarks seem to always cost close to the same amount the first time, and "improve" by a similar amount each time, despite the relevant code changes being merged into main.

Pinging @cmdupuis3 for your consideration, when you get the chance!

Can you provide a MCVE to repoduce the bug?

Metadata

Metadata

Assignees

Labels

benchmarkingRelated to benchmarks, memory usage, and/or time profilingbugSomething isn't working

Type

No type

Projects

Status
📝 To-Do

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions