From accbc3c93f27eb16065f6e9a25ac56c0d790f767 Mon Sep 17 00:00:00 2001
From: ZY Liu <236001964+liuzhengyang699@users.noreply.github.com>
Date: Sat, 10 Oct 2026 23:42:25 +0800
Subject: [PATCH] fix(mcts): follow tree selection through to a leaf

---
 optillm/mcts.py              | 12 ++++----
 tests/test_mcts_selection.py | 54 ++++++++++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+), 7 deletions(-)
 create mode 100644 tests/test_mcts_selection.py

diff --git a/optillm/mcts.py b/optillm/mcts.py
index 2baf35b3..5ade5ba2 100644
--- a/optillm/mcts.py
+++ b/optillm/mcts.py
@@ -44,12 +44,10 @@ def __init__(self, simulation_depth, exploration_weight, client, model, request_
 
     def select(self, node: MCTSNode) -> MCTSNode:
         logger.debug(f"Selecting node. Current node visits: {node.visits}, value: {node.value}")
-        if not node.children:
-            logger.debug("Node has no children. Returning current node.")
-            return node
-        selected_node = max(node.children, key=lambda c: c.value / (c.visits + 1e-8) + self.exploration_weight * np.sqrt(np.log(node.visits + 1) / (c.visits + 1e-8)))
-        logger.debug(f"Selected child node. Visits: {selected_node.visits}, Value: {selected_node.value}")
-        return selected_node
+        while node.children:
+            node = max(node.children, key=lambda c: c.value / (c.visits + 1e-8) + self.exploration_weight * np.sqrt(np.log(node.visits + 1) / (c.visits + 1e-8)))
+            logger.debug(f"Selected child node. Visits: {node.visits}, Value: {node.value}")
+        return node
 
     def expand(self, node: MCTSNode) -> MCTSNode:
         logger.debug(f"Expanding node. Current state: {node.state}")
@@ -235,4 +233,4 @@ def chat_with_mcts(system_prompt: str, initial_query: str, client, model: str, n
     final_state = mcts.search(initial_state, num_simulations)
     response = final_state.conversation_history[-1]['content'] if final_state.conversation_history else ""
     logger.info(f"MCTS chat complete. Final response: {response[:100]}...")
-    return response, mcts.completion_tokens
\ No newline at end of file
+    return response, mcts.completion_tokens
diff --git a/tests/test_mcts_selection.py b/tests/test_mcts_selection.py
new file mode 100644
index 00000000..603169b9
--- /dev/null
+++ b/tests/test_mcts_selection.py
@@ -0,0 +1,54 @@
+"""Offline regression tests for selection through the MCTS search tree."""
+
+from unittest.mock import Mock
+
+from optillm.mcts import MCTS, DialogueState, MCTSNode
+
+
+def make_node(query, parent=None, visits=1, value=0.0):
+    node = MCTSNode(DialogueState("system", [], query), parent=parent)
+    node.visits = visits
+    node.value = value
+    if parent is not None:
+        parent.children.append(node)
+    return node
+
+
+def test_selection_follows_uct_at_each_depth():
+    mcts = MCTS(0, 0.2, None, "test-model")
+    root = make_node("root", visits=10)
+    preferred = make_node("preferred", root, visits=5, value=4.0)
+    make_node("other", root, visits=5, value=1.0)
+    make_node("visited", preferred, visits=5, value=4.0)
+    unexplored = make_node("unexplored", preferred, visits=0)
+
+    assert mcts.select(root) is unexplored
+
+
+def test_selection_returns_leaf_unchanged():
+    mcts = MCTS(0, 0.2, None, "test-model")
+    leaf = make_node("leaf")
+
+    assert mcts.select(leaf) is leaf
+
+
+def test_search_expands_each_selected_leaf_once(monkeypatch):
+    mcts = MCTS(0, 0.2, None, "test-model")
+    initial_state = DialogueState("system", [], "question")
+    generated_from = []
+
+    def generate_actions(state):
+        generated_from.append(state.current_query)
+        return [state.current_query + " -> next"]
+
+    monkeypatch.setattr(mcts, "generate_actions", generate_actions)
+    monkeypatch.setattr(
+        mcts, "apply_action", lambda state, action: DialogueState("system", [], action)
+    )
+    monkeypatch.setattr(mcts, "evaluate_state", Mock(return_value=0.5))
+
+    mcts.search(initial_state, num_simulations=3)
+
+    assert generated_from == ["question", "question -> next", "question -> next -> next"]
+    assert mcts.root.visits == 3
+    assert len(mcts.root.children[0].children) == 1