Repository navigation
Conversation
Author
|
Hi @tlopex, could you take a look at these Relax/ONNX normalization correctness fixes when you have a chance? Please let me know if any further changes are needed. Thanks! |
Author
|
Could one of you take a look at these Relax/ONNX normalization correctness fixes when you have a chance, or point me to the right reviewer? I am keen to help get these fixes into TVM and happy to address feedback, add further regression tests, rebase, or split the changes if that would make review easier. The GitHub Actions checks also seem to need maintainer help with fork-workflow approval or a restart. I would appreciate any guidance on getting the appropriate checks running. Thank you for your time! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes three normalization correctness issues at their respective contract boundaries:
BatchNormalization.momentumto Relax's update-coefficient convention;LayerNormalizationMean and InvStdDev outputs instead of scalar placeholders;DecomposeOpsForTrainingconstructs reduction axes.The LayerNormalization statistics follow ONNX
stash_type=1and are computed in float32. The BatchNorm momentum conversion is kept in the ONNX frontend so existing Relax/TOPI semantics remain unchanged.Closes #20496
Closes #20503
Closes #20504
Tests:
pytest tests/python/relax/test_frontend_onnx.py -k "layer_norm or batch_norm" -q(8 passed)pytest tests/python/relax/test_transform_decompose_ops.py::test_batch_norm_training_negative_axis -q(1 passed)