Skip to content

Providing access to secret's metadata #11

Description

@cmorgia

Hi,
I'm working on my fork to slightly modify the source code in order to provide visibility on the secret's metadata.
This information is coming through DescribeSecret and it's already cached in the SecretCacheObject.

I would like to submit a pull request to your repository and my proposal would be to change the SecretCacheObject.getResult method to public and implement a SecretCache.describeSecret method like the following:

/**
     * Method to retrieve the description of a secret from AWS Secrets Manager.
     *
     * @param secretId
     *        The identifier for the secret being requested.
     * @return The string secret
     */
    public DescribeSecretResult describeSecret(final String secretId) {
        SecretCacheItem secret = this.getCachedSecret(secretId);
        return secret.getResult().clone();
    }

This way, accessing the secret's metadata does not request a second trip to the AWS SecretsManager or the implementation of a secondary cache.

This is my first pull request here, please be nice ;-)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions