Skip to content
This repository was archived by the owner on Sep 19, 2018. It is now read-only.
This repository was archived by the owner on Sep 19, 2018. It is now read-only.

mktime() cannot represent dates before the Unix epoch on Windows. #68

Description

@ericvw

For background of this issue, please refer to bloomberg/blpapi-http#167.

In summary, the root cause is due to how mktime() behaves on Windows. The documentation for WIN32 mktime indicates that for struct tm* before January 1, 1970, that -1 is returned. Which, when -1 is passed into V8::Date::New() it results in one second behind the Unix epoch (i.e., '1969-12-31 23:59:59').

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions