Skip to content

ci: skip startup benchmark comment on fork PRs - #230

Closed
edmundhung wants to merge 1 commit into
cloudflare:mainfrom
edmundhung:edmundhung/skip-fork-bench-comment
Closed

edmundhung wants to merge 1 commit into
cloudflare:mainfrom
edmundhung:edmundhung/skip-fork-bench-comment

Conversation

@edmundhung

Copy link
Copy Markdown
Member

Summary

  • Skip the sticky benchmark comment when the PR head and base repositories differ.
  • Keep benchmarking, job summary, and artifact upload running on fork PRs.

Fixes the read-only token failure observed in https://github.com/cloudflare/cf/actions/runs/37600114369/job/112728320218.

Validation

  • Parsed the workflow YAML and checked the fork guard.
  • git diff --check.

@edmundhung
edmundhung requested a review from a team as a code owner October 7, 2026 10:35
@pkg-pr-new

pkg-pr-new Bot commented Oct 7, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/cf@230

commit: e19d45f

@edmundhung

Copy link
Copy Markdown
Member Author

Closing in favor of #259.

@edmundhung edmundhung closed this Oct 11, 2026
@petebacondarwin

Copy link
Copy Markdown
Collaborator

Sorry I didn't spot this when I created my PR

@edmundhung

Copy link
Copy Markdown
Member Author

@petebacondarwin No worries. Your solution is cleaner 👍🏼

@edmundhung
edmundhung deleted the edmundhung/skip-fork-bench-comment branch October 11, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants