From a0b1325205c712ac6276419862bcf87d082d068a Mon Sep 17 00:00:00 2001 From: Oleksandr Lopatnov Date: Wed, 11 Nov 2026 09:30:23 +0200 Subject: [PATCH] Fix compilation of pingora-core on 32-bit Windows `from_raw_fd` cast the descriptor to `u64` before `TcpStream::from_raw_socket`, but `RawSocket` is `u32` on 32-bit Windows (`u64` only where the pointer is 64 bits), so `pingora-core` failed to compile for `i686-pc-windows-msvc` ("expected `u32`, found `u64`"). Cast to the `RawSocket` alias instead; on 64-bit Windows it is the same `u64` as before, so nothing changes there. Fixes #1119 Co-Authored-By: Claude Sonnet 5.5 --- pingora-core/src/listeners/l4.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pingora-core/src/listeners/l4.rs b/pingora-core/src/listeners/l4.rs index 132f75c16..2816746dd 100644 --- a/pingora-core/src/listeners/l4.rs +++ b/pingora-core/src/listeners/l4.rs @@ -26,7 +26,7 @@ use std::os::unix::io::{AsRawFd, FromRawFd}; #[cfg(unix)] use std::os::unix::net::UnixListener as StdUnixListener; #[cfg(windows)] -use std::os::windows::io::{AsRawSocket, FromRawSocket}; +use std::os::windows::io::{AsRawSocket, FromRawSocket, RawSocket}; use std::time::Duration; use std::{fs::Permissions, sync::Arc}; use tokio::net::TcpSocket; @@ -237,7 +237,8 @@ fn from_raw_fd(address: &ServerAddress, fd: i32) -> Result { #[cfg(unix)] let std_listener_socket = unsafe { std::net::TcpStream::from_raw_fd(fd) }; #[cfg(windows)] - let std_listener_socket = unsafe { std::net::TcpStream::from_raw_socket(fd as u64) }; + let std_listener_socket = + unsafe { std::net::TcpStream::from_raw_socket(fd as RawSocket) }; let listener_socket = TcpSocket::from_std_stream(std_listener_socket); // Note that we call listen on an already listening socket // POSIX undefined but on Linux it will update the backlog size