[cursor]

Summary

• Remove sentry.snuba.metrics.query_builder from the tool.mypy.overrides "sentry modules with typing issues" list in pyproject.toml
• Add explicit annotations in src/sentry/snuba/metrics/query_builder.py for previously untyped functions/params
• Remove non-essential overload stubs on generate_snql_for_action_by_fields that caused overload-match issues under strict checks

Testing

• .venv/bin/mypy --config-file /tmp/mypy-lite.ini src/sentry/snuba/metrics/query_builder.py
• .venv/bin/python -uSm tools.mypy_helpers.check_stronglist pyproject.toml

Notes

• Attempted to run SENTRY_MYPY_PRE_PUSH=1 .venv/bin/prek run -q mypy --files src/sentry/snuba/metrics/query_builder.py --stage pre-push, but the environment's mypy+djangostubs plugin initialization fails with Error constructing plugin instance of NewSemanalDjangoPlugin on the provisioned interpreter.

@armenzg could you please review this draft PR?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

  

[getsantry]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀