From 1806c1dd214fd223da662449de0810590fab6192 Mon Sep 17 00:00:00 2001 From: Frank3K <8014077+Frank3K@users.noreply.github.com> Date: Fri, 13 Nov 2026 23:16:34 +0100 Subject: [PATCH 1/2] fix(effects): show the glitch mode fallback hint in the error message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A stray unary plus turned the appended hint into NaN, so an invalid glitch-effect mode logged "…NaN" instead of "mode defaulting to 'sporadic'". --- packages/model-viewer-effects/src/effects/glitch.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-viewer-effects/src/effects/glitch.ts b/packages/model-viewer-effects/src/effects/glitch.ts index 70763a539b..4e7765f01b 100644 --- a/packages/model-viewer-effects/src/effects/glitch.ts +++ b/packages/model-viewer-effects/src/effects/glitch.ts @@ -70,7 +70,7 @@ export class MVGlitchEffect extends MVEffectBase { try { validateLiteralType(GLITCH_MODES, this.mode); } catch (e) { - console.error((e as Error).message + +'\nmode defaulting to \'sporadic\'') + console.error((e as Error).message + '\nmode defaulting to \'sporadic\''); } if (this.strength == 0) { (this.effects[0] as GlitchEffect).columns = 0; From c80bbdf9fb18d3f23fac39090619e2b284c168fa Mon Sep 17 00:00:00 2001 From: Diego Teran Date: Wed, 18 Nov 2026 11:54:32 -0800 Subject: [PATCH 2/2] test(effects): add glitch-spec and reset invalid mode to sporadic --- .../src/effects/glitch.ts | 6 +- .../src/test/effects/glitch-spec.ts | 86 +++++++++++++++++++ .../src/test/effects/index.ts | 1 + 3 files changed, 91 insertions(+), 2 deletions(-) create mode 100644 packages/model-viewer-effects/src/test/effects/glitch-spec.ts diff --git a/packages/model-viewer-effects/src/effects/glitch.ts b/packages/model-viewer-effects/src/effects/glitch.ts index 97c311f457..77ffcb995f 100644 --- a/packages/model-viewer-effects/src/effects/glitch.ts +++ b/packages/model-viewer-effects/src/effects/glitch.ts @@ -66,11 +66,13 @@ export class MVGlitchEffect extends MVEffectBase { [$updateProperties](): void { this.strength = clamp(this.strength, 0, 1); - this.mode = this.mode.toLowerCase() as GlitchMode; + const mode = (this.mode ?? 'sporadic').toLowerCase() as GlitchMode; try { - validateLiteralType(GLITCH_MODES, this.mode); + validateLiteralType(GLITCH_MODES, mode); + this.mode = mode; } catch (e) { console.error((e as Error).message + '\nmode defaulting to \'sporadic\''); + this.mode = 'sporadic'; } if (this.strength === 0) { (this.effects[0] as GlitchEffect).columns = 0; diff --git a/packages/model-viewer-effects/src/test/effects/glitch-spec.ts b/packages/model-viewer-effects/src/test/effects/glitch-spec.ts new file mode 100644 index 0000000000..05115d7b6a --- /dev/null +++ b/packages/model-viewer-effects/src/test/effects/glitch-spec.ts @@ -0,0 +1,86 @@ +/* @license + * Copyright 2026 Google LLC. All Rights Reserved. + * Licensed under the Apache License, Version 2.0 (the 'License'); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an 'AS IS' BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import {ModelViewerElement} from '@google/model-viewer'; +import {expect} from 'chai'; +import {GlitchEffect as PPGlitchEffect, GlitchMode as PPGlitchMode} from 'postprocessing'; + +import type {GlitchMode} from '../../effects/glitch.js'; +import {EffectComposer, GlitchEffect} from '../../model-viewer-effects.js'; + +suite('Glitch Effect', () => { + let element: ModelViewerElement; + let composer: EffectComposer; + let glitch: GlitchEffect; + let originalConsoleError: typeof console.error; + let errorLogs: string[]; + + setup(async () => { + errorLogs = []; + originalConsoleError = console.error; + console.error = (...args: unknown[]) => { + errorLogs.push(args.map(String).join(' ')); + }; + + element = new ModelViewerElement(); + composer = new EffectComposer(); + glitch = new GlitchEffect(); + composer.appendChild(glitch); + element.appendChild(composer); + document.body.appendChild(element); + await glitch.updateComplete; + }); + + teardown(() => { + console.error = originalConsoleError; + document.body.removeChild(element); + }); + + test('logs fallback hint and resets mode to sporadic when invalid', async () => { + glitch.mode = 'INVALID' as GlitchMode; + await glitch.updateComplete; + await glitch.updateComplete; + + expect(errorLogs).to.deep.equal([ + 'Validation Error: invalid is not a valid value. Expected sporadic | constant\nmode defaulting to \'sporadic\'', + ]); + expect(glitch.mode).to.equal('sporadic'); + expect(glitch.getAttribute('mode')).to.equal('sporadic'); + expect((glitch.effects[0] as PPGlitchEffect).mode) + .to.equal(PPGlitchMode.SPORADIC); + + glitch.strength = 0.25; + await glitch.updateComplete; + expect(errorLogs).to.have.lengthOf(1); + }); + + test( + 'applies valid modes case-insensitively without logging errors', + async () => { + glitch.mode = 'CONSTANT' as GlitchMode; + await glitch.updateComplete; + await glitch.updateComplete; + + expect(errorLogs).to.be.empty; + expect(glitch.mode).to.equal('constant'); + expect((glitch.effects[0] as PPGlitchEffect).mode) + .to.equal(PPGlitchMode.CONSTANT_WILD); + + glitch.strength = 0; + await glitch.updateComplete; + expect((glitch.effects[0] as PPGlitchEffect).mode) + .to.equal(PPGlitchMode.CONSTANT_MILD); + }); +}); diff --git a/packages/model-viewer-effects/src/test/effects/index.ts b/packages/model-viewer-effects/src/test/effects/index.ts index 1e8931e1bf..776984f2a0 100644 --- a/packages/model-viewer-effects/src/test/effects/index.ts +++ b/packages/model-viewer-effects/src/test/effects/index.ts @@ -14,3 +14,4 @@ */ import './color-grade-spec.js'; +import './glitch-spec.js';