Invalid state: ReadableStream is already closed

[Plopix]

Hello here,
I am starting to suspect something odd in @hono/node-server

We have random ReadableStream is already closed in the app, everything is try/catch but anyway it crashes the container.

We are also using GraphQL Yoga, I found out about this: #77

But I hesitate to do that because GraphQL Yoga is using @whatwg-node/fetch which is supposed to be a good abstraction.

the full trace is:

node:internal/webstreams/readablestream:1162
throw new ERR_INVALID_STATE.TypeError('ReadableStream is already closed');
^
TypeError [ERR_INVALID_STATE]: Invalid state: ReadableStream is already closed
at ReadableByteStreamController.close (node:internal/webstreams/readablestream:1162:13)
at node:internal/deps/undici/undici:1480:28
at node:internal/process/task_queues:151:7
at AsyncResource.runInAsyncScope (node:async_hooks:211:14)
at AsyncResource.runMicrotask (node:internal/process/task_queues:148:8)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
code: 'ERR_INVALID_STATE'
}
Node.js v22.13.1

Of course I don't reproduce easily, it happens randomly

Any idea? to identify the problem better?

[Plopix]

could it be related to this: https://github.com/honojs/node-server/blob/main/src/request.ts#L76

but it's so random (we have hundred of thousand request that are OK)

[usualoma]

Hi @Plopix. Thank you for the report. I will investigate.

[usualoma]

After thinking about it for a while, I think it would be better to catch it by ‘uncaughtException’ as follows.

process.on('uncaughtException', (err) => {
  console.error('uncaughtException:', err);
});

Where did the error occur?

The following areas are related, and it is due to a race condition in the loading and disconnecting of the response body.

https://github.com/nodejs/node/blob/v22.13.1/deps/undici/undici.js#L1480
https://github.com/nodejs/node/blob/v22.13.1/deps/undici/undici.js#L5578

Because it is an error in queueMicrotask(), I think Hono and node-server (this project) cannot catch the exception.

If this problem can be solved using the Node.js native APIs in GraphQL Yoga, I think it would be good to consider it.

[ImLunaHey]

using Readable.toWeb seems to have resolved this for me.

[cpojer]

I'm running into this issue as well. Repro:

• Use https://github.com/nkzw-tech/server-template as a base
• Add useGraphQLSSE as a plugin:

plugins: [
  useGraphQLSSE({
    endpoint: '/graphql/stream',
  }),
],

• Connect to it using GraphQL subscriptions with a client
• Press cmd+r to reload the client page in the browser → it crashes the Hono server.

[yusukebe]

Can you share a minimal project to reproduce it? The repo is too big and complex. It's hard to reproduce for me.

[yusukebe]

@cpojer First, thank you for sharing the project to reproduce your problem. I investigated and concluded it was the same as @usualoma 's comment: #233 (comment)

As it is said, this problem is caused by undici in Node.js, and this Node.js Adapter (or JavaScript layer) can't handle it.

So, to remove the error, I think the best solution is catching it with process.on('uncaughtException'). I created the PR #299 with the method. It's worth accepting.

Hey @usualoma! What do you think of this? If you agree to go with it, can you review it? (The test is nothing, since I don't know how to write one).

[ImLunaHey]

@yusukebe this approach seems problematic. using process.on('uncaughtException') to simply return is essentially suppressing the error rather than handling it properly. this hides the underlying issue instead of fixing it.

[yusukebe]

@ImLunaHey

Any idea to resolve this problem?

[ImLunaHey]

node-server needs to add state tracking to prevent multiple close() calls on the same ReadableStream. subsequent attempts should no-op.

[yusukebe]

@ImLunaHey

I've tried the same things (maybe), but they don't work well. Can you create a PR to do so?