From 75daddc3b95040c4e46f21fb7b1151d646244f6f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Baki=20Burak=20=C3=96=C4=9F=C3=BCn?= <63836730+bakiburakogun@users.noreply.github.com> Date: Sun, 23 Aug 2026 10:53:21 +0300 Subject: [PATCH] fix: throw UnknownActivityException in activity provider MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Nextcloud 30+ logs a deprecation warning on every notification fetch that touches a BBB activity: OCA\BigBlueButton\Activity\Provider::parse() threw \InvalidArgumentException which is deprecated. Throw \OCP\Activity\Exceptions\UnknownActivityException when the event is not known to your provider ... Use the dedicated exception instead. It exists since Nextcloud 30, well below the app's current minimum (33). Signed-off-by: Baki Burak Öğün <63836730+bakiburakogun@users.noreply.github.com> --- lib/Activity/Provider.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Activity/Provider.php b/lib/Activity/Provider.php index bec695db..98d900e0 100644 --- a/lib/Activity/Provider.php +++ b/lib/Activity/Provider.php @@ -4,6 +4,7 @@ use OCA\BigBlueButton\AppInfo\Application; use OCA\BigBlueButton\Db\RoomShare; +use OCP\Activity\Exceptions\UnknownActivityException; use OCP\Activity\IEvent; use OCP\Activity\IManager; use OCP\Activity\IProvider; @@ -70,7 +71,7 @@ public function __construct( public function parse($language, IEvent $event, ?IEvent $previousEvent = null) { if ($event->getApp() !== Application::ID) { - throw new \InvalidArgumentException(); + throw new UnknownActivityException(); } $this->l = $this->languageFactory->get(Application::ID, $language);