Repository navigation
Reformat SQL queries - #3663
Open
badboy wants to merge 1 commit into
Open
Reformat SQL queries#3663badboy wants to merge 1 commit into
badboy wants to merge 1 commit into
Conversation
chutten
approved these changes
Sep 25, 2026
chutten
left a comment
chutten
left a comment
Contributor
There was a problem hiding this comment.
Can we enforce this, and if not should we document it?
badboy
added this pull request to stack #3665
September 25, 2026 15:01
Member
Author
We cannot unless we introduce some custom logic doing it for us. rustfmt's format_strings is still unstable (and occasionally broken). Guess we can document it. |
badboy
force-pushed
the
reformat-sql-queries/quozpukxsytx
branch
from
October 5, 2026 10:17
7177239 to
fec040c
Compare
Member
Author
I just don't know where would be a good place. |
Contributor
A "Style Guide" page under https://mozilla.github.io/glean/dev/core/index.html that mentions the various |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting annoyed by the uneven indentation of SQL statements and the fact that we (=me!) used raw strings, which we don't need here. So now it's all the same.