Repository navigation
Avoid format machinery for concatenating the base identifier all the time - #3670
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
badboy
force-pushed
the
avoid-format-machinery-for-con/vnwrluvnmwoq
branch
from
October 5, 2026 14:26
f0aac96 to
a26c588
Compare
badboy
force-pushed
the
avoid-format-machinery-for-con/vnwrluvnmwoq
branch
from
October 5, 2026 14:34
a26c588 to
c324b0e
Compare
badboy
marked this pull request as ready for review
October 13, 2026 09:05
chutten
approved these changes
Oct 13, 2026
chutten
left a comment
chutten
left a comment
Contributor
There was a problem hiding this comment.
We're saving the change to CMD to move category.name to codegen time for a later go?
Contributor
|
(Also, seeing as we don't know whether this will be noticeable, I'm guessing that's why there's no CHANGELOG?) |
Member
Author
That would be #3684.
Yeah, this is not a user-visible change. It's purely internal formatting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent profile we looked at the format machinery showed up. So what if we just avoid that, and also avoid small allocations (by doing one appropriately sized?)
I ran this teeny tiny microbenchmark earlier locally (on my M4 mac), of course nowhere close to the real thing: https://gist.github.com/badboy/f33a2867f0bb32105bd14dfa7aa1a9a6
We should gather a profile on Desktop to proof it's worth it.