Skip to content

Move anal tooth part_of to holothurian cloaca (follow-up to #3789) - #3790

Open
ai4c-agent[bot] wants to merge 4 commits into
masterfrom
ai4c-agent-pull_request-3789-run2033-anal-tooth-move
Open

ai4c-agent[bot] wants to merge 4 commits into
masterfrom
ai4c-agent-pull_request-3789-run2033-anal-tooth-move

Conversation

@ai4c-agent

@ai4c-agent ai4c-agent Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #3789, per @cmungall's note that the anal tooth should be moved to the holothurian cloaca.

Change

UBERON:0012468 (anal tooth):

  • before: intersection_of: part_of UBERON:0001353 ! anal region
  • after: intersection_of: part_of UBERON:1200005 ! holothurian cloaca

Single-line diff on src/ontology/uberon-edit.obo.

Rationale

Holothurian anal teeth ring the terminal opening of the holothurian cloaca (the structure added in #3789); the previous part_of anal region was a vertebrate-centric approximation from the term's original 2012 placement, from before holothurian cloaca existed.

The new part_of is anatomically more precise and keeps the (non-)homology commitments internally consistent: holothurian cloaca is deliberately not asserted to be a kind of vertebrate cloaca, and anal tooth remains outside the vertebrate tooth lineage (is_a tooth-like structure, not tooth).

The in_taxon NCBITaxon:7586 (Echinodermata) is left as-is; it is now redundant (reasoner will infer the tighter Holothuroidea via the new part_of), but tightening it is a separate change.

Test plan

  • obo-checkout.pl / obo-checkin.pl round-trip clean
  • robot convert -f obo reserialisation clean
  • Reasoning / CI green on this branch

🤖 Generated with Claude Code

Per @cmungall follow-up on PR #3789: reparent `anal tooth` from
`part_of UBERON:0001353 ! anal region` to
`part_of UBERON:1200005 ! holothurian cloaca`.

Rationale: holothurian anal teeth ring the terminal opening of the
holothurian cloaca (the structure added in #3789); the "anal region"
part_of was a vertebrate-centric approximation inherited from the
original 2012 placement. The new part_of is more anatomically precise
and keeps the (non-)homology commitments consistent — the holothurian
cloaca is deliberately not asserted to be a kind of vertebrate cloaca,
and anal tooth remains outside the vertebrate tooth lineage.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@ai4c-reviewer

ai4c-reviewer Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Claude finished @ai4c-agent[bot]'s task in 29s —— View job


PR review: #3790

  • Read the diff and the two terms involved
  • Checked that the new parent is consistent
  • Submitted an approving review

Result: I approved the PR. UBERON:1200005 (holothurian cloaca) exists, isn't obsolete, and is in Holothuroidea, so it fits the anal tooth's Echinodermata in_taxon. The one suggestion is optional: tighten the now-redundant in_taxon in a follow-up. I didn't run reasoning or CI, so confirm CI is green before merging.

ai4c-reviewer[bot]
ai4c-reviewer Bot previously approved these changes Oct 15, 2026

@ai4c-reviewer ai4c-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Hierarchy and parents are consistent
  • Definitions and supporting references look adequate
  • Obsolete or replacement handling is safe (n/a)
  • OBO and ODK conventions appear preserved
  • No obvious CI, auth, or workflow regression

Single-line change: anal tooth (UBERON:0012468) now part_of UBERON:1200005 (holothurian cloaca) instead of anal region. UBERON:1200005 exists, is not obsolete, and has in_taxon NCBITaxon:7705 (Holothuroidea), which is consistent with the anal tooth's in_taxon Echinodermata. The new parent matches the definition (papillae around the anus of Holothuriidae) and avoids implying homology with the vertebrate cloaca or tooth.

🔵 SUGGESTION: the in_taxon Echinodermata is now redundant. Tightening it to Holothuroidea can be a follow-up, as the PR notes.

Please make sure reasoning/CI is green before merging.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor
This PR modifies some logical definitions. See details below:

Number of classes with modified logical definitions: 1

anal tooth

No changes in inferred subclasses.

@ai4c-reviewer

ai4c-reviewer Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Claude finished @matentzn's task in 50s —— View job


Review of #3790 (re-review after the repoint commit)

  • Hierarchy and parents are consistent
  • Definitions and supporting references look adequate
  • Obsolete or replacement handling is safe
  • OBO and ODK conventions appear preserved
  • No obvious CI, auth, or workflow regression (I didn't run CI or the reasoner, so check the CI status yourself)

Result: no 🔴 or 🟡 issues. I can't submit a formal approval, so that's up to a human reviewer.

What I checked

  • The latest commit changes anal tooth (UBERON:0012468) from part_of UBERON:1200005 to part_of UBERON:1200386 ! holothurian cloaca.
  • UBERON:1200386 exists in uberon-edit.obo and isn't obsolete.
    • It is holothurian cloaca, is_a subdivision of digestive tract, and in_taxon NCBITaxon:7705 (Holothuroidea).
    • That taxon sits under the anal tooth's Echinodermata in_taxon, so the taxon constraint is compatible.
  • The term's comment says no homology with vertebrate cloaca is asserted. The anal tooth stays under tooth-like structure and not tooth, so the two terms are consistent.
  • A search for id: UBERON:1200005 finds no stanza, so the old ID no longer resolves. The repoint is needed.
  • The diff against HEAD~1 is the one-line change. The git diff origin/master...HEAD form reported no merge base in this checkout, so I couldn't use it.
  • The "Removed subclasses: owl:Nothing" note from the logical-definition bot is expected. It means the class was unsatisfiable before and isn't now.

Suggestions

  • 🔵 PR description: it still says UBERON:1200005. Update it to UBERON:1200386.
  • 🔵 Redundant in_taxon: as the PR notes, in_taxon Echinodermata is now redundant with the Holothuroidea taxon the reasoner infers from the new part_of. It's fine to tighten that in a follow-up.
  • 🔵 Other references to the old ID: if other open PRs or branches still use UBERON:1200005, repoint them to UBERON:1200386 too.

@ai4c-reviewer

ai4c-reviewer Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Claude finished @matentzn's task in 44s —— View job


Review of #3790 after the latest push

  • Hierarchy and parents are consistent
  • Definitions and supporting references look adequate
  • Obsolete or replacement handling is safe (n/a)
  • OBO and ODK conventions appear preserved
  • No obvious CI, auth, or workflow regression (I did not run reasoning or CI)

The diff against origin/master is one line in src/ontology/uberon-edit.obo. In anal tooth (UBERON:0012468), part_of UBERON:0001353 ! anal region becomes part_of UBERON:1200386 ! holothurian cloaca.

Corrects the earlier review. The earlier review and the PR description cite UBERON:1200005. After the renumbering in #3798, holothurian cloaca is UBERON:1200386, and the branch already uses that ID (commit 1f4db86). I checked UBERON:1200386:

  • It exists and is not obsolete.
  • It is is_a subdivision of digestive tract.
  • It has in_taxon NCBITaxon:7705 (Holothuroidea), which fits the anal tooth's in_taxon Echinodermata.
  • Its comment says no homology with the vertebrate cloaca is asserted, which matches the PR's intent.

🔵 Suggestion: update the PR description so UBERON:1200005 reads UBERON:1200386. The description is now stale.

🔵 Suggestion: as the PR notes, in_taxon Echinodermata on the anal tooth is now redundant. Tightening it to Holothuroidea can be a follow-up.

I found nothing blocking. Please confirm the reasoning and CI checks pass before merging.

@matentzn matentzn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dismiss my review.

synonym: "perianal tooth" RELATED []
intersection_of: UBERON:0003913 ! tooth-like structure
intersection_of: part_of UBERON:0001353 ! anal region
intersection_of: part_of UBERON:1200386 ! holothurian cloaca

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that anal teeth are really part of the cloaca. Samyn et al. 2006 (Zootaxa 1138, https://www.vliz.be/imisdocs/publications/78114.pdf), Actinopyga diagnosis: "anus dorsal to terminal, guarded by five, nearly always prominent, heavily calcified terminal tube feet (= "anal teeth")". So they're podia, body wall / water vascular appendages ringing the anal opening, not part of the terminal gut chamber. And since this is an intersection_of, anything tooth-like that's part of the holothurian cloaca gets classified as an anal tooth.

The old part_of anal region was at least right about position. I'd keep that, and at most add adjacent_to the holothurian cloaca (or its opening).

@@ -152884,7 +152884,7 @@ synonym: "calcified anal papilla" RELATED []
synonym: "cloacal tooth" RELATED []
synonym: "perianal tooth" RELATED []
intersection_of: UBERON:0003913 ! tooth-like structure

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one predates the PR, but while we're here: tooth-like structure is defined as an organ "found in the mouth or pharynx ... used in procuring or masticating food" and carries capable_of_part_of mastication. Anal teeth don't chew anything. This is the terminological trap @cmungall described on #3789: the label says "tooth" and the axioms bought into it.

I'd drop the intersection_of and go with something like:

is_a: UBERON:0008247 ! tube foot
relationship: part_of UBERON:0001353 ! anal region

plus a def that says what they are, e.g. "A heavily calcified tube foot, typically one of five, that guards the anus in some Holothuriidae (e.g. Actinopyga)." Then in_taxon could go to Holothuroidea (NCBITaxon:7705) while we're at it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant