Repository navigation
Move anal tooth part_of to holothurian cloaca (follow-up to #3789) - #3790
ai4c-agent[bot] wants to merge 4 commits into
Conversation
Per @cmungall follow-up on PR #3789: reparent `anal tooth` from `part_of UBERON:0001353 ! anal region` to `part_of UBERON:1200005 ! holothurian cloaca`. Rationale: holothurian anal teeth ring the terminal opening of the holothurian cloaca (the structure added in #3789); the "anal region" part_of was a vertebrate-centric approximation inherited from the original 2012 placement. The new part_of is more anatomically precise and keeps the (non-)homology commitments consistent — the holothurian cloaca is deliberately not asserted to be a kind of vertebrate cloaca, and anal tooth remains outside the vertebrate tooth lineage. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Claude finished @ai4c-agent[bot]'s task in 29s —— View job PR review: #3790
Result: I approved the PR. UBERON:1200005 (holothurian cloaca) exists, isn't obsolete, and is in Holothuroidea, so it fits the anal tooth's Echinodermata |
There was a problem hiding this comment.
- Hierarchy and parents are consistent
- Definitions and supporting references look adequate
- Obsolete or replacement handling is safe (n/a)
- OBO and ODK conventions appear preserved
- No obvious CI, auth, or workflow regression
Single-line change: anal tooth (UBERON:0012468) now part_of UBERON:1200005 (holothurian cloaca) instead of anal region. UBERON:1200005 exists, is not obsolete, and has in_taxon NCBITaxon:7705 (Holothuroidea), which is consistent with the anal tooth's in_taxon Echinodermata. The new parent matches the definition (papillae around the anus of Holothuriidae) and avoids implying homology with the vertebrate cloaca or tooth.
🔵 SUGGESTION: the in_taxon Echinodermata is now redundant. Tightening it to Holothuroidea can be a follow-up, as the PR notes.
Please make sure reasoning/CI is green before merging.
This PR modifies some logical definitions. See details below:Number of classes with modified logical definitions: 1 anal toothNo changes in inferred subclasses. |
…uest-3789-run2033-anal-tooth-move
|
Claude finished @matentzn's task in 50s —— View job Review of #3790 (re-review after the repoint commit)
Result: no 🔴 or 🟡 issues. I can't submit a formal approval, so that's up to a human reviewer. What I checked
Suggestions
|
|
Claude finished @matentzn's task in 44s —— View job Review of #3790 after the latest push
The diff against Corrects the earlier review. The earlier review and the PR description cite
🔵 Suggestion: update the PR description so 🔵 Suggestion: as the PR notes, I found nothing blocking. Please confirm the reasoning and CI checks pass before merging. |
matentzn
left a comment
There was a problem hiding this comment.
Please dismiss my review.
| synonym: "perianal tooth" RELATED [] | ||
| intersection_of: UBERON:0003913 ! tooth-like structure | ||
| intersection_of: part_of UBERON:0001353 ! anal region | ||
| intersection_of: part_of UBERON:1200386 ! holothurian cloaca |
There was a problem hiding this comment.
Make sure that anal teeth are really part of the cloaca. Samyn et al. 2006 (Zootaxa 1138, https://www.vliz.be/imisdocs/publications/78114.pdf), Actinopyga diagnosis: "anus dorsal to terminal, guarded by five, nearly always prominent, heavily calcified terminal tube feet (= "anal teeth")". So they're podia, body wall / water vascular appendages ringing the anal opening, not part of the terminal gut chamber. And since this is an intersection_of, anything tooth-like that's part of the holothurian cloaca gets classified as an anal tooth.
The old part_of anal region was at least right about position. I'd keep that, and at most add adjacent_to the holothurian cloaca (or its opening).
| @@ -152884,7 +152884,7 @@ synonym: "calcified anal papilla" RELATED [] | |||
| synonym: "cloacal tooth" RELATED [] | |||
| synonym: "perianal tooth" RELATED [] | |||
| intersection_of: UBERON:0003913 ! tooth-like structure | |||
There was a problem hiding this comment.
This one predates the PR, but while we're here: tooth-like structure is defined as an organ "found in the mouth or pharynx ... used in procuring or masticating food" and carries capable_of_part_of mastication. Anal teeth don't chew anything. This is the terminological trap @cmungall described on #3789: the label says "tooth" and the axioms bought into it.
I'd drop the intersection_of and go with something like:
is_a: UBERON:0008247 ! tube foot
relationship: part_of UBERON:0001353 ! anal region
plus a def that says what they are, e.g. "A heavily calcified tube foot, typically one of five, that guards the anus in some Holothuriidae (e.g. Actinopyga)." Then in_taxon could go to Holothuroidea (NCBITaxon:7705) while we're at it.
Follow-up to #3789, per @cmungall's note that the anal tooth should be moved to the holothurian cloaca.
Change
UBERON:0012468(anal tooth):intersection_of: part_of UBERON:0001353 ! anal regionintersection_of: part_of UBERON:1200005 ! holothurian cloacaSingle-line diff on
src/ontology/uberon-edit.obo.Rationale
Holothurian anal teeth ring the terminal opening of the holothurian cloaca (the structure added in #3789); the previous
part_of anal regionwas a vertebrate-centric approximation from the term's original 2012 placement, from beforeholothurian cloacaexisted.The new
part_ofis anatomically more precise and keeps the (non-)homology commitments internally consistent:holothurian cloacais deliberately not asserted to be a kind of vertebratecloaca, andanal toothremains outside the vertebrate tooth lineage (is_a tooth-like structure, nottooth).The
in_taxon NCBITaxon:7586 (Echinodermata)is left as-is; it is now redundant (reasoner will infer the tighter Holothuroidea via the new part_of), but tightening it is a separate change.Test plan
obo-checkout.pl/obo-checkin.plround-trip cleanrobot convert -f oboreserialisation clean🤖 Generated with Claude Code