Repository navigation
Conversation
Fix code examples in the Context, ContextKey and ContextStorage Javadoc that do not compile when copied, and correct the wrap(Callable) Javadoc that described a Runnable.
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-13 03:26 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8934 +/- ##
============================================
+ Coverage 90.65% 90.66% +0.01%
- Complexity 10887 10890 +3
============================================
Files 1015 1015
Lines 29731 29731
Branches 3876 3876
============================================
+ Hits 26953 26957 +4
Misses 1860 1860
+ Partials 918 914 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thswlsqls
marked this pull request as ready for review
October 13, 2026 03:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8931
Description
Contextclass andContext.with(ContextKey, Object)Javadoc:CRED_KEY.get()(no such method) →Context.current().get(CRED_KEY).ContextKeyJavadoc: staticContext.with(KEY, ...)→Context.current().with(KEY, ...). ContextKey update example code #7420 renamedwithValuestowithbut kept the static call.ContextStorageJavadoc: drop the>line prefix, replace the nonexistentRequestContextStoragewithContextStorage, fixpublic Scope T attach, and add the missing semicolons.Context.wrap(Callable)Javadoc: sayCallableinstead ofRunnable.io.opentelemetry.context.propagation.Testing done
./gradlew :context:check :context:javadocpassed.javac --release 8againstcontext/build/classes/java/main(with stub helpers): all compile. The previous versions fail withcannot find symbol,non-static method ... cannot be referenced from a static context, and';' expected.