Skip to content

[Analysis] Result.php: findings deferred to baseline #66

Description

@tyrsson

Context

Part of #60.

Data

  • unused-property: $numberOfRows is declared but never read or written. Present since the initial laminas-db import (389b937); confirmed via full file history it is not a regression introduced by this PR.
  • missing-constructor: $resource (mysqli|mysqli_result|mysqli_stmt) has no default value and no constructor; it's set via initialize() instead. A nullable-plus-guard rewrite was already shown not to resolve cleanly in Statement.php (Statement.php uninitialized-property findings need local-variable narrowing rewrite #61) due to mago not retaining property null-narrowing across statements; the same limitation applies here.
  • possibly-undefined-int-array-index/mixed-array-assignment in the loadDataFromMysqliStatement() dereference loop (for ($i = 0, $count = count(...); $i < $count; $i++)): mago cannot correlate the loop bound with the size of the parallel keys/values arrays it iterates.

These findings will be captured in a mago baseline rather than fixed or suppressed inline.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    Status
    Todo

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions