Skip to content

Data::ObjectDriver::Driver::BaseCache::lookup_multi optimistic assumption #28

Description

@sewi-cpan

Data::ObjectDriver::Driver::BaseCache::lookup_multi does this after fetching items from memcached:
if (scalar keys %$got == @$ids) {
The idea looks good: If memcached get_multi returned the same number of items as requested, all must be within the result, but that's wrong!
We're currently experiencing a Cache::Memcached bug sometimes destroying a key name if the response is being read in two system calls. The key returned from get_multi is not the one requested (which is the same actually returned from memcached). That's another bug which must be fixed, but Data::ObjectDriver::Driver::BaseCache::lookup_multi would repair it by asking the next layer (typically SQL database).
The assumption about requested and returned counts prevents the repair but returnes completely empty objects which lead to follow-up errors.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions