feat: Adopt AGP v9 - #4263
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Android build tooling and adjusts React Native Gesture Handler’s Android Gradle configuration to work across newer AGP/Kotlin setups.
Changes:
- Bump Gradle wrapper to 9.4.1 in the library package and the basic example app.
- Add AGP-version/property-based fallback to apply
kotlin-androidonly when needed. - Rework
sourceSets.mainconfiguration to use a Kotlin-specific source set API.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-gesture-handler/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper version for the gesture handler Android project. |
| packages/react-native-gesture-handler/android/build.gradle | Adds AGP/Kotlin fallback logic and changes source set configuration. |
| apps/basic-example/android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper version for the example app. |
| apps/basic-example/android/gradle.properties | Adds properties to opt out of AGP built-in Kotlin and new DSL behavior. |
| apps/basic-example/android/app/build.gradle | Switches default ProGuard config to the optimized variant for release builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Android build configuration now conditionally applies the Kotlin plugin and registers Reanimated and SVG integration paths as Kotlin source directories. ChangesAndroid Kotlin build configuration
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-native-gesture-handler/android/build.gradle`:
- Around line 219-229: Update the kotlin source-directory configuration to
preserve AGP 8.0–8.4 compatibility: replace the unconditional directories.add
calls in the shouldUseCommonInterfaceFromReanimated and
shouldUseCommonInterfaceFromRNSVG branches with srcDirs, or guard
directories.add behind a full AGP-version check that requires 8.5.0 or newer.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d2884032-3d2f-444a-b40d-ff887924e43f
📒 Files selected for processing (1)
packages/react-native-gesture-handler/android/build.gradle
|
Hi @hurali97! I took the liberty of updating this PR, could you please take a look and confirm that we can merge? 😅 |
Description
This PR is rasied following the second phase of the RFC around AGP v9 adoption:
RFC: react-native-community/discussions-and-proposals#1006
The gist of this PR is to make Gesture Handler AGP v9 compliant with backward compatibility. The main scope of changes is the
react-native-gesture-handler/android/build.gradle. The rest of the changes can be considered temporary.The rest changes include:
Gradletov9.4.1proguard-android-optimizeproguard filegradle.propertiesIdeally, we should not enable the opt outs and leverage the AGP 9 built-in kotlin and newDSL. However, if we do not do it, then other libraries which are not yet AGP v9 compliant starts to fail. Hence, we need to keep the opt outs enabled for a while. For the context, react-native starting from 0.87.x will ship with AGP v9 and opt outs enabled by default for the new apps, which is the first phase of AGP v9 adoption.
With the second phase when the libraries starts adoption AGP v9, we can eventually remove the opt outs from Basic Example.
Test plan
To test this PR, we need to do a few steps:
agpversion to9.2.1andkotlinto2.2.0inreact-native-gradle-pluginreact-native-gradle-pluginThis step is only required because we have RN version on 0.85.2 and
AGP+kotlinbump will be shipped with 0.87.x.Verified by locally patching Reanimated and Worklet, making those AGP v9 compliant and removing the opt outs to test the changes in the PR
agp-9.mp4
Verified these changes work with AGP 8
agp-8.mov