Skip to content

Validator should verify that ExtractIcon target contains an icon #2

Description

@3D1T0R

Currently, the validator considers App\AppInfo\appinfo.ini: [Control]:ExtractIcon as valid if the file exists. However, it should not be considered valid if it does not contain an icon.

As ExtractIcon is only supposed to be used in cases where the icon can't legally be copied to the App\AppInfo\appicon.ico and App\AppInfo\appicon_*.png files, it doesn't necessarily make sense to have it require all of the different icon variants that are supposed to be in appicon.ico, but I suppose if we get #1 working satisfactorily, it wouldn't hurt to check the ExtractIcon target for all of them and warn if some aren't present.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions