Skip to content

fix: remove to_huggingface.py step from Gemma3-4B LoRA E2E test - #5217

Merged
copybara-service[bot] merged 1 commit into
mainfrom
emma/fix-lora-0914
Sep 14, 2026
Merged

copybara-service[bot] merged 1 commit into
mainfrom
emma/fix-lora-0914

Conversation

@chiajunglien

Copy link
Copy Markdown
Collaborator

Description

Remove the final to_huggingface conversion step (Step 5) from the Gemma3-4B LoRA end-to-end test (tests/end_to_end/tpu/gemma3/4b/test_gemma3_lora.sh).

This step was not part of the original LoRA e2e flow; it was added by #4361.
Since then it has been breaking our DAG, so this PR reverts the script back to the LoRA-only flow.

DAG Error Log

Tests

https://efdb2a1d6c2c435b8b7de77690c286a9-dot-us-central1.composer.googleusercontent.com/dags/maxtext_e2e_tpu_post_training/grid?tab=logs&task_id=gemma3-4b.lora-gemma3-4b.lora-v5p-8.run_model.wait_for_workload_completion&dag_run_id=manual__2026-09-11T09%3A17%3A56%2B00%3A00

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a temporary patch _patch_tunix_moe_weight_keys in maxtext_vllm_rollout.py to add missing MoE keys (specifically wo) to Tunix's zero-pad branch, preventing a ShapeMismatchError during rollout. It also removes the Hugging Face checkpoint conversion step from the Gemma3 LoRA end-to-end test. Feedback suggests simplifying the set operations in the patch function by directly using set operators on the existing set-like objects instead of performing redundant type conversions.

Comment thread src/maxtext/integration/vllm/maxtext_vllm_rollout.py Outdated
@chiajunglien chiajunglien changed the title Emma/fix lora 0914 fix: remove to_huggingface.py step from Gemma3-4B LoRA E2E test Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@copybara-service
copybara-service Bot merged commit cc361de into main Sep 14, 2026
74 of 79 checks passed
@copybara-service
copybara-service Bot deleted the emma/fix-lora-0914 branch September 14, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants