fix: remove to_huggingface.py step from Gemma3-4B LoRA E2E test - #5217
Merged
Merged
Conversation
chiajunglien
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
shuningjin,
vipannalla and
xibinliu
as code owners
September 14, 2026 09:17
There was a problem hiding this comment.
Code Review
This pull request introduces a temporary patch _patch_tunix_moe_weight_keys in maxtext_vllm_rollout.py to add missing MoE keys (specifically wo) to Tunix's zero-pad branch, preventing a ShapeMismatchError during rollout. It also removes the Hugging Face checkpoint conversion step from the Gemma3 LoRA end-to-end test. Feedback suggests simplifying the set operations in the patch function by directly using set operators on the existing set-like objects instead of performing redundant type conversions.
chiajunglien
force-pushed
the
emma/fix-lora-0914
branch
from
September 14, 2026 09:18
3894c22 to
b9d699e
Compare
to_huggingface.py step from Gemma3-4B LoRA E2E test
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SurbhiJainUSC
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the final
to_huggingfaceconversion step (Step 5) from the Gemma3-4B LoRA end-to-end test (tests/end_to_end/tpu/gemma3/4b/test_gemma3_lora.sh).This step was not part of the original LoRA e2e flow; it was added by #4361.
Since then it has been breaking our DAG, so this PR reverts the script back to the LoRA-only flow.
DAG Error Log
Tests
https://efdb2a1d6c2c435b8b7de77690c286a9-dot-us-central1.composer.googleusercontent.com/dags/maxtext_e2e_tpu_post_training/grid?tab=logs&task_id=gemma3-4b.lora-gemma3-4b.lora-v5p-8.run_model.wait_for_workload_completion&dag_run_id=manual__2026-09-11T09%3A17%3A56%2B00%3A00
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.