feat: add Arch/Manjaro Linux support to setup.sh - #1397
feat: add Arch/Manjaro Linux support to setup.sh#1397DashratRajpurohit wants to merge 3 commits into
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe setup flow now recognizes Arch-based distributions, including Manjaro, and installs their required system packages with ChangesArch-based setup support
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/setup.sh`:
- Around line 42-57: Update the setup entrypoint gate in scripts/setup.js to
recognize Arch-based distributions consistently with the Arch branch in
setup.sh, ensuring the supported setup command can reach it. In the pacman
dependency list, remove rustup and pyenv while leaving their initialization to
the existing later bootstrap logic; if Arch support is not intended, remove the
entire Arch branch instead.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d210ef5c-fa32-4c85-880e-e973cadfb7a9
📒 Files selected for processing (1)
scripts/setup.sh
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/setup.sh (1)
42-55: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winAvoid partial upgrades on Arch Linux.
Using
pacman -Sywithout-urefreshes the package database and installs new packages against it, which can cause partial upgrades. Partial upgrades are explicitly unsupported on Arch Linux and can lead to a broken system (e.g., shared library incompatibilities).Consider using
pacman -Syuto upgrade the system alongside the installation, or simplypacman -Sto install using the existing synced databases. Usingpacman -Syuis the safest approach for ensuring compatibility.🛠️ Proposed fix
- sudo pacman -Sy --needed --noconfirm \ + sudo pacman -Syu --needed --noconfirm \🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/setup.sh` around lines 42 - 55, Update the Arch-based dependency installation command in the setup script from pacman -Sy to pacman -Syu, preserving the existing --needed, --noconfirm flags and package list to avoid unsupported partial upgrades.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@scripts/setup.sh`:
- Around line 42-55: Update the Arch-based dependency installation command in
the setup script from pacman -Sy to pacman -Syu, preserving the existing
--needed, --noconfirm flags and package list to avoid unsupported partial
upgrades.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8fdd3ed1-80e3-4fa1-a3a1-91f38591ada1
📒 Files selected for processing (2)
scripts/setup.jsscripts/setup.sh
Fixes #1381
Description
This PR adds a detection and package installation branch for Arch-based Linux distributions (e.g., Arch Linux, Manjaro, Mabox Linux, EndeavourOS) in
scripts/setup.sh.Changes Included:
/etc/arch-release,/etc/manjaro-release, orpacmancommand).pacman:webkit2gtk-4.1(Tauri WebView engine)base-devel(Development build tools)curl,wget,file,openssl,librsvgxdotool(Provideslibxdoheaders/libs)libayatana-appindicator(System indicator support)nodejs&npm(In Arch Linux,npmis packaged separately fromnodejs)rustup&pyenvVerification:
bash -n scripts/setup.sh.Summary by CodeRabbit