Repository navigation
fix(pcie): PCIe bridge windows to include final BAR - #648
Merged
Merged
Conversation
- The common baremetal PCIe enumeration code recorded the final allocated 32-bit BAR base as the resource limit. When the limit matched the allocation cursor, get_resource_base_32() subtracted 1 MiB before programming the Root Port memory window. - For devices with 1 MiB-aligned endpoint BARs, this caused the Root Port non-prefetchable or prefetchable forwarding window to stop one BAR early. - Track the inclusive end address for the last allocated 32-bit BAR instead of the BAR base, and stop subtracting BAR_INCREMENT during bridge window programming. - Also replace the Memory Base/Limit address fields explicitly when updating the Type 1 registers so stale address bits from the previous register value cannot survive. - Tested with a PCIe hierarchy containing multiple 1 MiB endpoint BARs behind one Root Port. The Root Port NP window now covers the final BAR range. Change-Id: I75d3085f8c5b64f531c4e8f3f893720c7db1aaa5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I75d3085f8c5b64f531c4e8f3f893720c7db1aaa5