Repository navigation
Vary v2 campaign funding: real ERC1155 prices, cross-camp backers, retroactive reimbursement - #214
Merged
Merged
Conversation
…troactive reimbursement - V2 fund-project actions buy varied receipt quantities at real prices; v1 legacy actions keep the fixed purchase unit - Abortion common-ground bridge project: 20 prerequisite purchases across two left/right camp backers reach the 2 USDZZZ threshold; four later actions donate 1 USDZZZ total into the reimbursement waterfall - Remote publisher wallets get explicit gas provisioning; belief writes carry explicit gas limits (25-user stage revert fix) - Local run and remote stages 10/25/100 all mined and reconciled 1:1 with zero discrepancies; SDK-derived reimbursement check matched - Canary preflight wording matches the 2026-09-28 readiness decision - Step 14 checked off in TESTNET-SIMULATION-PLAN.md with run report
AdamSpitz
commented
Oct 2, 2026
AdamSpitz
left a comment
AdamSpitz
left a comment
Owner
Author
There was a problem hiding this comment.
Review receipt.
Reviewed full diff vs dev: planner funding metadata + validation, per-action funding costs in writer/checks/provisioning, camp-backing and retroactive reimbursement flow, canary gate rewording (per 2026-09-28 readiness decision), services.sh --no-deps fix. fake-data-generation tests 85/85, UI testData tests 6/6, tsc clean both workspaces. No blocking findings.
Reviewed-with: pi
Reviewed-files: 18
Reviewed-commit: ce62e99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
funding.kind: early/retroactive, tokenId, tokenCount, camp) matching the 0.01/0.10 ERC1155 receipt prices, with planner validation that receipt price equals amount and retroactive funding depends on earlier purchases.campaignActionFundingCost(action)per action instead of a flat cost;set-beliefwrites go through directsetBelief/setBeliefsInBatchcalls with deterministic gas;approvalConfirmationsconfigurable (1 local, 3 remote).scripts/services.shuses--no-depson app-service recreate so hardhat-deploy isn't rerun; run publications now include project links, and the UI test-data project list no longer requireserc1155and prefers real titles.needs-adamplaceholders →readyForExecution(read-only verifier is still the pre-execution gate).Testing
npm test --workspace fake-data-generation— 85 pass (new planner bridge-funding, provisioning publisher-gas, canary gate tests)npx vitest run src/commonality/testData/testDataDocuments.test.ts(ui) — 6 passtsc --noEmitclean infake-data-generationanduifake-data-generation/campaigns/medium-realistic-v2-*.md