Skip to content

docs: clarify benchmark model settings option - #5656

Open
shijian0-eng wants to merge 1 commit into
Aider-AI:mainfrom
shijian0-eng:codex/5131-docs
Open

shijian0-eng wants to merge 1 commit into
Aider-AI:mainfrom
shijian0-eng:codex/5131-docs

Conversation

@shijian0-eng

Copy link
Copy Markdown

Summary

  • Clarify that the benchmark script uses --read-model-settings=<filename.yml>.
  • Distinguish it from the main aider CLI option, --model-settings-file .
  • Cross-reference the model settings documentation.

Fixes #5131

Scope

This is a docs-only change. benchmark/benchmark.py is intentionally unchanged.

Tests

  • D:\pytorchAnaconda\envs\pytorch2\python.exe benchmark/benchmark.py --help with PYTHONPATH=.: passed
  • D:\pytorchAnaconda\envs\pytorch2\python.exe -m pip check: passed
  • git diff --check: passed

@shijian0-eng

Copy link
Copy Markdown
Author

Hi maintainers, a quick follow-up: the CI workflows expired while awaiting approval, so no jobs were run.

This PR only clarifies the model settings options in the documentation; benchmark/benchmark.py is unchanged. When you have a chance, could you please help re-trigger and approve the workflows?

Thank you for your time!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

benchmark.py uses --read-model-settings but main cli + docs say --model-settings-file

1 participant