Repository navigation
[O2B-1636] Display snippet of content and allow users to click on row on log-overivew - #2284
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
- Coverage 46.45% 46.34% -0.11%
==========================================
Files 1054 1056 +2
Lines 17384 17429 +45
Branches 3166 3179 +13
==========================================
+ Hits 8076 8078 +2
- Misses 9308 9351 +43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
The formatter alters literal identifiers, and the new preview assertion rejects valid seeded content.
2 open issues
What changed in this PR
This PR adds log-content previews and row-click navigation to log tables, preparing them for mobile use while preserving separate links within each row.
Changes:
- Add formatted content snippets below log titles, excluding embedded tables.
- Replace dedicated “More” buttons with title links and shared row-click navigation.
- Add formatter tests and update browser tests for previews and navigation.
| File | Description |
|---|---|
| test/public/tags/detail.test.js | Update navigation to use the title link. |
| test/public/runs/detail.test.js | Test title-link and row-click navigation. |
| test/public/logs/overview.test.js | Test snippets, navigation, and removal of dedicated buttons. |
| test/public/envs/detailsPage.test.js | Verify embedded logs omit snippets. |
| test/lib/public/utilities/formatting/index.js | Register snippet formatter tests. |
| test/lib/public/utilities/formatting/formatLogSnippet.test.js | Test formatting, title removal, and truncation. |
| lib/public/views/Tags/Details/tagDetailsComponent.js | Enable log-row navigation in tag details. |
| lib/public/views/Runs/Details/runDetailsComponent.js | Enable log-row navigation in run details. |
| lib/public/views/Logs/Overview/index.js | Apply shared log-row navigation. |
| lib/public/views/Logs/format/logsRowsConfiguration.js | Define row-click behavior and interactive-element exclusions. |
| lib/public/views/Logs/ActiveColumns/logsActiveColumns.js | Add title links and previews; remove action buttons. |
| lib/public/views/LhcFills/Detail/lhcFillDetailsComponent.js | Enable log-row navigation in fill details. |
| lib/public/views/Environments/Details/EnvironmentDetailsPage.js | Enable log-row navigation in environment details. |
| lib/public/utilities/formatting/formatLogSnippet.js | Format and truncate log-content previews. |
Review effort: Balanced
4 tasks done
graduta
added a commit
that referenced
this pull request
Oct 26, 2026
…snippet (#2300) - `formatLogSnippet` (added in #2284) strips markdown with regular expressions that are quadratic on long lines (for example ` __a b` repeated: about 2s for 192KB, and log texts have no maximum length). Only the beginning of the content can end up in the snippet, so only its first 2000 characters are now parsed - A unit test checks that a huge content is processed in less than 500ms. The `formatLogSnippet` unit tests were run locally and pass; the rest of the suite was not run locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: