Repository navigation
[O2B-1636] Merge columns of the log overview into denser ones and give the title the most space - #2285
Merged
Conversation
…a single two-line column The creation date is displayed with its author below it. The author column is kept hidden to provide its filter, and sorting by author is dropped.
… overview into a single Passes column Data and simulation passes are displayed in their own labelled lines. Their columns are kept hidden to provide their filters.
…to a single column Runs and environments are displayed in their own labelled lines. Their columns are kept hidden to provide their filters, and sorting by them is dropped.
…title in the log overview The replies and attachments columns are removed, their counts are displayed as icons at the end of the title line.
…ay the first tag with a popover listing all of them Only the first tag is displayed with the number of remaining ones, hovering the displayed tags opens a popover with the full list.
…he log overview The column is renamed Linked to and displays runs, environments and LHC fills in their own labelled lines. The LHC fills column is kept hidden to provide its filter.
Columns widths are rebalanced to sum up to 100% so that the title and its content snippet predominate.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2285 +/- ##
==========================================
- Coverage 46.34% 46.28% -0.07%
==========================================
Files 1056 1056
Lines 17429 17440 +11
Branches 3179 3183 +4
==========================================
- Hits 8078 8072 -6
- Misses 9351 9368 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… the screen On wide screens the created and tags columns are narrower, as their content has a fixed size, to leave more space to the title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Runs,Env,Fills). The Runs, Environments and LHC Fills columns are merged into it.Data,Sim).Notable changes for developers:
logsActiveColumnscolumns whose content is now displayed in a merged column (author,runs,environments,lhcFills,dataPasses,simulationPasses) are kept as hidden columns to provide their filters. The filters' URL parameters are unchanged.formatLogSnippetutility (markdown to one-line plain text, preserving code spans and identifiers likeLHC22b_apass1), with unit tests.logsRowsConfigurationrows configuration, shared by every table displaying logs, to make rows clickable by delegating to the title link. Untrusted (programmatic) clicks are ignored as popovers forward clicks made in their content to the hidden original content, which lives in the row.formatTagsListhas a newlimitoption (flex mode only).#row<id>-title-link,-title-value,-title-snippet,-replies-count,-attachments-count,-created-date,-created-author,-runs,-environments,-lhcFills,-passes-data,-passes-simulation,-tags.formatLogSnippet.Changes made to the database:
🤖 Generated with Claude Code