Repository navigation
[O2B-1361] Pass the detector ids to the QC summary when filtering runs by detector QC - #2299
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2299 +/- ##
=======================================
Coverage 46.01% 46.01%
=======================================
Files 1070 1070
Lines 17609 17609
Branches 3261 3261
=======================================
Hits 8102 8102
Misses 9507 9507 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
DPLnotion removal ([O2B-1361] Remove DPL notion from detectors #1991) renameddplDetectorIdstodetectorsIdinstead ofdetectorIdsinGetAllRunsUseCase, soqcFlagSummaryService.getSummarysilently ignored its detector filter. Results were still correct (the filter on runs only reads the requested detectors) but the summary was computed for all detectors, which is slower on big data passesChanges made to the database: