Skip to content

[O2B-1361] Pass the detector ids to the QC summary when filtering runs by detector QC - #2299

Merged
graduta merged 1 commit into
mainfrom
fix/O2B-1361/detector-ids-in-runs-qc-filter
Oct 26, 2026
Merged

graduta merged 1 commit into
mainfrom
fix/O2B-1361/detector-ids-in-runs-qc-filter

Conversation

@graduta

@graduta graduta commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Filtering runs by detector QC (not-bad fraction) no longer computes the QC summary for every detector

Notable changes for developers:

  • The DPL notion removal ([O2B-1361] Remove DPL notion from detectors #1991) renamed dplDetectorIds to detectorsId instead of detectorIds in GetAllRunsUseCase, so qcFlagSummaryService.getSummary silently ignored its detector filter. Results were still correct (the filter on runs only reads the requested detectors) but the summary was computed for all detectors, which is slower on big data passes

Changes made to the database:

  • None

@graduta
graduta requested a review from isaachilly as a code owner October 26, 2026 15:57
@graduta graduta added bug Something isn't working backend labels Oct 26, 2026
@graduta graduta self-assigned this Oct 26, 2026
@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.01%. Comparing base (b6921bc) to head (9f98a23).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2299   +/-   ##
=======================================
  Coverage   46.01%   46.01%           
=======================================
  Files        1070     1070           
  Lines       17609    17609           
  Branches     3261     3261           
=======================================
  Hits         8102     8102           
  Misses       9507     9507           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta
graduta merged commit cf7cb88 into main Oct 26, 2026
26 checks passed
@graduta
graduta deleted the fix/O2B-1361/detector-ids-in-runs-qc-filter branch October 26, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Development

Successfully merging this pull request may close these issues.

1 participant