Skip to content

Fix DBBACKUP_GPG_ALWAYS_TRUST being ignored - #678

Open
NotAFlightRisk wants to merge 1 commit into
Archmonger:masterfrom
NotAFlightRisk:fix-gpg-always-trust
Open

NotAFlightRisk wants to merge 1 commit into
Archmonger:masterfrom
NotAFlightRisk:fix-gpg-always-trust

Conversation

@NotAFlightRisk

Copy link
Copy Markdown

Description

The docs say DBBACKUP_GPG_ALWAYS_TRUST stays off unless you turn it on. It's actually been on for everyone with DBBACKUP_GPG_RECIPIENT set, since the recipient line in settings.py assigns to GPG_ALWAYS_TRUST too - so False is ignored and backups get encrypted to keys GPG hasnt been told to trust.

It'll catch a few people out on upgrade though. If your recipient key isn't trusted in GPG and you never set the option, encrypted backups will start failing with "invalid recipient" until you trust the key or set it to True. I've put that in the changelog entry.

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant