Repository navigation
Fix DBBACKUP_GPG_ALWAYS_TRUST being ignored - #678
Open
NotAFlightRisk wants to merge 1 commit into
Open
NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The docs say
DBBACKUP_GPG_ALWAYS_TRUSTstays off unless you turn it on. It's actually been on for everyone withDBBACKUP_GPG_RECIPIENTset, since the recipient line insettings.pyassigns toGPG_ALWAYS_TRUSTtoo - soFalseis ignored and backups get encrypted to keys GPG hasnt been told to trust.It'll catch a few people out on upgrade though. If your recipient key isn't trusted in GPG and you never set the option, encrypted backups will start failing with "invalid recipient" until you trust the key or set it to
True. I've put that in the changelog entry.Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).