Repository navigation
Fix CodeQL by removing unnecessary Azure SDK bootstrap - #860
Open
Moary Chen (moarychan) wants to merge 1 commit into
Open
Moary Chen (moarychan) wants to merge 1 commit into
Moary Chen (moarychan) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the unnecessary Azure SDK source build from the samples' CodeQL workflow.
The CodeQL runs for #859 failed before scanning the samples because building Azure SDK
main(7.5.0-beta.1) could not resolvemaven-surefire-plugin:3.6.0from the Azure DevOps feed (HTTP 401). The samples use released Spring Cloud Azure 7.4.0 dependencies and do not need this bootstrap.Does this introduce a breaking change?
Pull Request Type
How to Test
git diff --checkpasses.mvn -f pom.xml --batch-mode --update-snapshots --no-transfer-progress -Dmaven.repo.local=<fresh-directory> -DskipTests verifypasses for all 98 reactor projects on JDK 21.verifywas attempted but Docker Compose tests could not connect to the local Docker daemon. No CI tests or analysis steps are disabled by this change.What to Check
Both CodeQL matrix jobs should proceed directly to sample checkout, initialization, autobuild, and analysis without building Azure SDK
main.