fix(security): 2 improvements across 2 files

[tomaioo]

Summary

fix(security): 2 improvements across 2 files

Problem

Severity: High | File: cli/azd/cmd/deps_record.go:L20

The deps_record.go file sets InsecureSkipVerify: true on the TLS configuration when running in record mode. This disables certificate validation, making the application vulnerable to man-in-the-middle attacks. While this is intended for testing with a recording proxy, the code comment indicates this is for 'self-signed certificates, which is what the recording proxy uses.' The issue is that this is a production code path (guarded by build tag but still shipped) that completely disables TLS verification. Additionally, http.DefaultTransport is mutated globally, which affects all HTTP clients in the process.

Solution

1. Instead of disabling all certificate verification, add the recording proxy's CA certificate to a custom certificate pool. 2. Avoid mutating http.DefaultTransport globally; create a new transport instance for the specific client. 3. Consider using a more targeted approach like tls.Config.RootCAs with the proxy's certificate rather than InsecureSkipVerify.

Changes

• cli/azd/cmd/deps_record.go (modified)
• cli/azd/extensions/azure.ai.agents/internal/cmd/debug.go (modified)

[microsoft-github-policy-service]

Thank you for your contribution @tomaioo! We will review the pull request and get back to you soon.

[microsoft-github-policy-service]

@tomaioo please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

1. Definitions.
   “Code” means the computer software code, whether in human-readable or machine-executable form,
   that is delivered by You to Microsoft under this Agreement.
   “Project” means any of the projects owned or managed by Microsoft and offered under a license
   approved by the Open Source Initiative (www.opensource.org).
   “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
   Project, including but not limited to communication on electronic mailing lists, source code control
   systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
   discussing and improving that Project, but excluding communication that is conspicuously marked or
   otherwise designated in writing by You as “Not a Submission.”
   “Submission” means the Code and any other copyrightable material Submitted by You, including any
   associated comments and documentation.
2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
   Project. This Agreement covers any and all Submissions that You, now or in the future (except as
   described in Section 4 below), Submit to any Project.
3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
   Should You wish to Submit materials that are not Your original work, You may Submit them separately
   to the Project if You (a) retain all copyright and license information that was in the materials as You
   received them, (b) in the description accompanying Your Submission, include the phrase “Submission
   containing materials of a third party:” followed by the names of the third party and any licenses or other
   restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
   guidelines concerning Submissions.
4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
   for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
   Submission is made in the course of Your work for an employer or Your employer has intellectual
   property rights in Your Submission by contract or applicable law, You must secure permission from Your
   employer to make the Submission before signing this Agreement. In that case, the term “You” in this
   Agreement will refer to You and the employer collectively. If You change employers in the future and
   desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
   and secure permission from the new employer before Submitting those Submissions.
5. Licenses.

• Copyright License. You grant Microsoft, and those who receive the Submission directly or
  indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
  Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
  the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
  parties.
• Patent License. You grant Microsoft, and those who receive the Submission directly or
  indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
  Your patent claims that are necessarily infringed by the Submission or the combination of the
  Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
  import or otherwise dispose of the Submission alone or with the Project.
• Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
  No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
  granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
   licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
   have disclosed under Section 3). You represent that You have secured permission from Your employer to
   make the Submission in cases where Your Submission is made in the course of Your work for Your
   employer or Your employer has intellectual property rights in Your Submission by contract or applicable
   law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
   have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
   You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
   REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
   EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
   PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
   NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
7. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
   You later become aware that would make Your representations in this Agreement inaccurate in any
   respect.
8. Information about Submissions. You agree that contributions to Projects and information about
   contributions may be maintained indefinitely and disclosed publicly, including Your name and other
   information that You submit with Your Submission.
9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
   the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
   Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
   exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
   defenses of lack of personal jurisdiction and forum non-conveniens.
10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

[Copilot]

Pull request overview

This PR is framed as two "security improvements." In cli/azd/cmd/deps_record.go (compiled only under //go:build record) it removes InsecureSkipVerify: true and stops mutating the global http.DefaultTransport/http.DefaultClient, returning a dedicated *http.Client instead. In the azure.ai.agents extension debug.go, it moves the debug log file into the system temp dir and hardens AZD_EXT_DEBUG parsing. The debug.go changes are clean, but the deps_record.go changes break the record build both at compile time and at runtime.

Changes:

• Remove InsecureSkipVerify and global transport/client mutation from the record-mode HTTP client, returning a new client instead.
• Switch the AI Agents extension debug log to os.CreateTemp and make isDebug explicitly handle empty/invalid AZD_EXT_DEBUG.
• (Unintended) Leave crypto/tls imported but unused, and drop the only mechanism that let azd trust the recording proxy's self-signed certificate.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cli/azd/cmd/deps_record.go	Drops InsecureSkipVerify and global transport mutation; leaves crypto/tls unused (won't compile under -tags=record) and removes the only trust path for the recording proxy's self-signed cert, breaking functional tests.
cli/azd/extensions/azure.ai.agents/internal/cmd/debug.go	Moves debug logs to a temp file and hardens AZD_EXT_DEBUG parsing to match existing conventions; no blocking issues.

[jongio]

This PR removes InsecureSkipVerify from deps_record.go and refactors logging in debug.go, but introduces several issues that need to be addressed before merging.

deps_record.go: This file only compiles under the record build tag (test infrastructure, not production code). The recording proxy uses self-signed certificates, which is why InsecureSkipVerify exists. The same pattern is used intentionally in cli/azd/extensions/azure.ai.agents/internal/pkg/recordproxy/transport_record.go. Removing it without adding the proxy's CA certificate to a custom pool (as the PR description proposes) will break all recorded test sessions with TLS handshake failures. Additionally, removing the only usage of crypto/tls while keeping the import will cause a compile error under the record build tag.

debug.go: The CreateTemp then Close then OpenFile pattern introduces a TOCTOU race condition. The original code was correctly annotated with //nolint:gosec because the filename is derived from time.Now() (not user input). Moving logs to a temp directory with a random suffix also makes them much harder to find when debugging.

[jongio]

Removing this line leaves crypto/tls imported but unused (line 9), which causes a compile error under the record build tag. Beyond that, this InsecureSkipVerify is required: the recording proxy uses a self-signed certificate. Without it (and without adding the proxy's CA to a custom cert pool), every HTTPS request through the proxy will fail with a TLS verification error. The same pattern exists in extensions/azure.ai.agents/internal/pkg/recordproxy/transport_record.go:41-44 for the same reason.

Since deps_record.go only compiles with //go:build record (test infrastructure), it never runs in production. The security risk described in the PR body doesn't apply here.

[jongio]

This CreateTemp then Close then OpenFile pattern is a TOCTOU (time-of-check-time-of-use) race: between Close() and the subsequent OpenFile(), another process could modify or remove the file. This is actually less secure than the original code.

The original filename (azd-ai-agents-YYYY-MM-DD.log in CWD) was deliberately predictable so developers can find debug logs. Moving to a temp directory with a random suffix (azd-ai-agents-XYZ123.log in os.TempDir()) makes logs effectively unfindable.

The //nolint:gosec annotation on the original was correct: the G304 warning (file path from variable) doesn't apply when the variable is derived entirely from time.Now().Format(), not user input.

[jongio]

This refactor is functionally identical to the original. strconv.ParseBool("") returns (false, err) and the original debug, _ := ... discards the error, returning false. The new code does the same thing in more lines. Not harmful, but not needed either.