Repository navigation
Conversation
chore/orval-codegen-migration Conflicts: - package.json: keep both the spec and postinstall scripts, and both orval and patch-package Also restore the APIClient import in lib/api/god.api.ts. develop's new useRefreshEmployerLoginMetrics hook still uses it, and the gods migration had removed it.
…enerated client: services.ts and use-student-api.tsx.
…ponse (generated files only)
…ient and delete the hand-written fetch client (everything else)
## Summary Generated companion to the server OpenAPI metadata fixes, targeting `chore/orval-codegen-migration` rather than the default branch. - Copy the corrected server spec and regenerate with Orval 7.13.2. - Replace ambiguous object types with string enums, nullable timestamp strings, typed dictionaries, student preferences, and public-job models. - Reflect optional query parameters and the actual employer-update fields. - Changes are confined to `lib/api/generated`; no handwritten services, state management, or Orval configuration changes. Companion server PR: BetterInternship/API-Server-V2#154. Existing generated fetch functions remain in use; this does not introduce generated React Query hooks. ## Verification - Client application-source TypeScript check passes with zero diagnostics. - Repeated client generation is byte-for-byte stable. - Copied client spec matches the server spec. - Diff whitespace checks pass. ## Scope / limitations The focused TypeScript check excludes existing stale `.next` route types and `orval.config.ts`, whose local Orval dependency is unavailable. Generation used cached Orval 7.13.2 with the existing configuration. No full client production build or browser/E2E tests were run. Remaining server business-failure response mismatches are outside this PR.
…n-migration Conflict resolutions: - services.ts: kept the generated-client calls; carried develop's session-hint set/clear into signOut and getMyProfile. - ctx-auth.tsx: kept both import sets. - top-page.server.ts: took develop's ISR rewrite as-is (it uses the new /top-pages/categories endpoint, which the generated client lacks). - god.api.ts: develop's rebuild-top-pages mutation moved off the deleted APIClient onto careerFetch (route not in the generated spec yet). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Push recruiters to upload their logos upon registration so we can accumulate company logos to eventually display on listings. Will be helpful together with the landing redesign to make the site more trustworthy.
Redesigned listing creation to be less intimidating to go through. Bundles several component visual changes to improve consistency since inconsistencies are more noticeable otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.