[FIX] networking: print int length with %d in NETWORKING_DEBUG output - #2311
Merged
Conversation
net_send_cc() takes `int len` but the debug line printed it with %u. The other two specifiers in these blocks were corrected in #2307; this one was missed. The blocks only compile with -DNETWORKING_DEBUG=ON, so nothing shipped was affected. Enabling them and building with -Wall -Wextra -Wformat=2 now reports no format diagnostics at all; the two remaining -Wpointer-sign warnings on write_block() are pre-existing and unrelated to the debug output. Picked up from #2175 by Varadraj75, who reported the underlying issue (#2174) and caught this specifier there; that PR was closed after going five months without a rebase.
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 06179f7...:
NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
This PR does not introduce any new test failures. However, some tests are failing on both master and this PR (see above). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 749b355...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2307, picking up the one bit its sibling PR got right.
net_send_cc()takesint len, but its debug line printed it with%u:#2307 fixed the other two specifiers in these blocks (
%u→%zuwherelenissize_t) but missed this one. #2175 by @Varadraj75 had it right — that PR was closed after five months without a rebase, so this ports the remaining fix.Scope
These blocks only compile under
-DNETWORKING_DEBUG=ON, so no shipped build was affected.gccdoesn't diagnose%uagainstint(same width), which is why it survived the sweep on #2307 — I found it by auditing every specifier in the enabled blocks rather than trusting the compiler.Verification
Enabling the debug blocks and compiling with
-Wall -Wextra -Wformat=2, both with and without-DDISABLE_RUST:[C] Sending %u byteswith anintThe two remaining
-Wpointer-signwarnings onwrite_block()are pre-existing, in live code, and unrelated to the debug output — left alone deliberately.clang-formatclean. One line, one file.Credit: @Varadraj75 reported #2174 and caught this specifier in #2175.