Repository navigation
Fix split-memory path of TV denoising (tv_proximal.cu) - #806
Open
AnderBiguri wants to merge 1 commit into
Open
AnderBiguri wants to merge 1 commit into
AnderBiguri wants to merge 1 commit into
Conversation
Three bugs in the path used when the image does not fit in GPU memory (splits>1), not covered by #804: - When reloading d_src for the last chunk, the memset zeroed d_pz instead of d_src. It ran on stream 1 while d_pz was being uploaded and negated on stream 4, so pz on the last chunk was fully or partly reset each time, depending on timing. - At the end of each split, the copies of u/px/py/pz back to the host were not waited for. The first device of the next split reads its halo from the part of the host array the last device of this split is still writing. Synchronize all devices at the end of each split, as GD_TV.cu and GD_AwTV.cu already do. - buffer_length could be computed as 0 when a GPU has little spare memory, so the main loop never advanced. Clamp it to 1; memory for that case is already checked above. Not run on GPU hardware. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L6n1VLmYDf6QeHNsr3mDwy
Member
Author
|
@jeffdaily You may want to have a look at this, as my agent has suggested these extra cases. I can not see any issue with them, but I don't have the hardware to test all cases, so if you could do that in yours, it would be fantastic |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs in the path used when the image does not fit in GPU memory (splits>1), not covered by #804:
Not run on GPU hardware.
Claude-Session: https://claude.ai/code/session_01L6n1VLmYDf6QeHNsr3mDwy