Repository navigation
Conversation
Member
|
Thanks @saqibkh ! I will leave this open for a bit, as I want to first to a push of making a good CI/tests for TIGRE (hopefully less computationally costly) and then see if this CI idea of simulating a GPU is worth doing for TIGRE. This is nevertheless quite interesting, so thanks. |
This was referenced Nov 9, 2026
Open
Author
|
Thanks, no rush. If it helps, I can adjust the workflow to whatever test set you settle on. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI here has no job that executes the CUDA code:
build.ymlonly builds wheels and an sdist, because the hosted runners have no GPU. This adds a separate, optional workflow.github/workflows/gpu-sim.ymlthat builds pytigre with CUDA 13.0 and runs the Python tests that need a GPU on a simulated NVIDIA H100, using PantheonSim (via thepantheongpu/setup-pantheonsimaction, pinned by SHA). I am the author of PantheonSim, so please weigh this accordingly.It does not touch the existing workflows and is not meant to be a required check. A simulator cannot reproduce hardware-specific behavior or timing, so it complements real-GPU testing and does not replace it.
What it does:
pip install .and runspytestundervgpu run.setup.pybuilds-gencode=arch=compute_X,code=sm_X(SASS) for every architecture nvcc lists. The workflow therefore applies a two-linesedtosetup.pyon the runner (not in the repo) so it builds a singlecompute_90PTX target. The extensions already link the sharedlibcudart, so nothing else needs to change.test_*.pymodules inPython/testsand skipstest_config_gen.py.algorithm_test.py,stdout_test.pyandtest_config_gen.pydo not import (tigre.demosis not packaged in the install, andstdout_test.pyimports Python 2'sStringIO), so they are left out; I did not change them.workflow_dispatchandpull_requestlimited toCommon/,Python/,setup.py,pyproject.tomland the workflow itself. A concurrency group cancels superseded runs, withpermissions: contents: read.What is left out:
Result on a fork: the run passed. 70 tests passed and none were skipped, including the 9 Krylov smoke tests (
test_krylov_smoke.py, which run Ax and Atb on a 64^3 phantom with 50 views) and the GPU-id tests. The whole job took about 24 minutes on a cold cache, of which about 15.7 minutes was the action setting up the simulator on its first run. The build step took about 48 seconds and the tests about 7 minutes.Run: https://github.com/saqibkh/TIGRE/actions/runs/42660482796