Repository navigation
Fix projection plotting for one-dimensional and ZYZ angle arrays - #812
Merged
AnderBiguri merged 1 commit intoNov 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projection plotting fails for supported angle inputs: animation indexes one-dimensional angles as a two-dimensional array, and static views cannot format three-component ZYZ angles correctly. Lowercase
dim="t"also misses animation setup, and detector U/V slices can incorrectly index the view-angle array.Normalize and validate
(views,),(views, 1)and(views, 3)angle arrays, display the first angle component only for projection views, and retain the animation on the plot object. PreserveplotSinogramand empty-GIF-filename behavior.Validation: 22 CPU/Agg tests cover static slices, first/last animation frames, angle shapes, invalid inputs and empty GIF filenames. Upstream
aea5346has 16 failures and 6 passes; all 22 pass with the fix. The tests load the plotting module directly and require no compiled TIGRE extensions.