Skip to content

Fix projection plotting for one-dimensional and ZYZ angle arrays - #812

Merged
AnderBiguri merged 1 commit into
CERN:masterfrom
liu005:pr/plotproj-angle-shapes-20261110
Nov 10, 2026
Merged

AnderBiguri merged 1 commit into
CERN:masterfrom
liu005:pr/plotproj-angle-shapes-20261110

Conversation

@liu005

@liu005 liu005 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Projection plotting fails for supported angle inputs: animation indexes one-dimensional angles as a two-dimensional array, and static views cannot format three-component ZYZ angles correctly. Lowercase dim="t" also misses animation setup, and detector U/V slices can incorrectly index the view-angle array.

Normalize and validate (views,), (views, 1) and (views, 3) angle arrays, display the first angle component only for projection views, and retain the animation on the plot object. Preserve plotSinogram and empty-GIF-filename behavior.

Validation: 22 CPU/Agg tests cover static slices, first/last animation frames, angle shapes, invalid inputs and empty GIF filenames. Upstream aea5346 has 16 failures and 6 passes; all 22 pass with the fix. The tests load the plotting module directly and require no compiled TIGRE extensions.

@AnderBiguri
AnderBiguri merged commit f935e74 into CERN:master Nov 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants