Repository navigation
Review corrections: DESIGN.md wording, doubled warning prefix, a weak test - #198
Merged
Merged
Conversation
The design doc's attention-price paragraph narrated history and overstated when `voro next` and the queue agree; the milestone sections carried before-and-after phrasing; the CLI printed the [costs] warning with two prefixes; the milestone prompts called the title label a column; and the refine test's assertion passed on almost any status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013boiGeBBHDAVTKti1Knvog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections from review of the milestone and attention-price changes. Only items 3 and 4 change behaviour.
voro nextand the first ready queue row now name the same task, milestones aside, only under two stated conditions: the dispatch WIP cap is not reached (at the cap the queue drops dispatch rows whilenextignores the gate), and a ready row makes the ten-row cut.max_running/[costs]paragraph. "Left over from the attention price" now reads as a statement of the design.voro.tomlwith a[costs]table: the CLI printedvoro: warning: the [costs] table …. main.rs now prints the warning text as it is, so the line readswarning: the [costs] table …. The core string keeps itswarning:prefix, so the TUI status line and the Config screen do not change. The new integration testcrates/voro/tests/costs_table_warning.rsruns the binary with a scratchXDG_CONFIG_HOMEand checks that exactly one line, with one prefix, mentions[costs]. With the old print the test fails.r_and_capital_r_refine_a_proposed_milestone: the test context now sets up a stub agent with aplanverb. The test asserts thatRqueues arefinelaunch whoseRefineLaunch.task_idis the milestone, and that the prompt file it writes contains the milestone guidance ("This task is a milestone").Verification:
cargo test --workspacepasses (554 + 424 unit tests, 2 integration tests),cargo clippy --workspace --all-targets -- -D warningsis clean, andgrep -n -E "2026-0|47th|used to" docs/DESIGN.mdprints nothing.