Remove ruby-version files - #145
Merged
Merged
Conversation
Member
|
This is required for CI. You can edit the gemspec to ignore and update this PR. |
As a library, the project should compatible with a range of Ruby as described in the gemspec. So, the project doesn't need to be pinned to a specific Ruby version. I discovered this see the ruby-version deep in the bundler directory: ./vendor/bundle/ruby/4.0.0/gems/with_advisory_lock-7.5.0/.ruby-version Other projects, such as Rails itself, do not ship a .ruby-version file.
jdufresne
force-pushed
the
rm-ruby-version
branch
from
August 5, 2026 10:31
f567add to
b609913
Compare
Contributor
Author
|
In CI, the Ruby version is specified directly on the setup-ruby step, so these files are ignored. See: After rebasing, all CI is green. Is there a different CI job that I should look at? To me, this still looks unnecessary and safe to remove. |
Member
|
Damn it , i was half asleep, that legacy ci. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a library, the project is compatible with a wide range of Ruby versions as described in the gemspec. So, the project doesn't need to be pinned to a single specific Ruby version.
I discovered this file deep in the bundler directory during routine greps:
./vendor/bundle/ruby/4.0.0/gems/with_advisory_lock-7.5.0/.ruby-version
Other projects, such as Rails itself, do not distribute a .ruby-version file. So no need here either.