Conversation
Signed-off-by: Norio Nomura <norio.nomura@gmail.com> (cherry picked from commit 7726dd1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
vmnet を独立した Go パッケージとして追加する前に、macOS のバージョン判定を内部パッケージへ移します。PR #205 の既存コミットを cherry-pick した差分です。
変更
osversionの実装をinternal/osversionへ移します。検証
make test/run TARGET=TestAvailableVersionが成功しました。Test_fetchMajorMinorVersionとTest_macOSBuildTargetAvailableが成功しました。PR #205 からの切り出しです。