Repository navigation
fix(docpars): install with cargo on Apple Silicon - #287
Open
jorgeluisd wants to merge 1 commit into
Open
jorgeluisd wants to merge 1 commit into
jorgeluisd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #288
On Apple Silicon,
brew install denisidoro/tools/docparssucceeds but installs an x86_64 binary, so everydocs::parsecall fails withBad CPU type in executablewhen Rosetta isn't installed. The recipe now installsdocparswith cargo on arm64 macOS. Intel macOS and Linux keep the current flow.Verification
bash -nandshellcheck -s bash -S warningpass on the recipe.dot package add docparswith stubbedbrew,cargoanduname: arm64 macOS uses cargo; Intel macOS and Linux behave as before.cargo install docparsbuilds a working arm64 binary on Apple Silicon without Rosetta.