-
Notifications
You must be signed in to change notification settings - Fork 5
ci: adopt the shared public-repo-hygiene workflow, drop the in-tree copy #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattmillerai
wants to merge
5
commits into
main
Choose a base branch
from
chore/adopt-shared-hygiene
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eccb933
ci: adopt the shared public-repo-hygiene workflow, drop the in-tree copy
mattmillerai 8a0bb22
Merge origin/main, resolve semantic conflict in public-repo-hygiene h…
mattmillerai e51e7b7
Merge remote-tracking branch 'origin/main' into chore/adopt-shared-hy…
mattmillerai f78c6d7
Merge branch 'main' into chore/adopt-shared-hygiene
wei-hai 1d17d95
docs: qualify what the workflows_ref pin guarantees, and name the new…
mattmillerai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Description: Thin caller for the shared public-repo-hygiene reusable workflow | ||
| # in Comfy-Org/github-workflows, which owns the checker AND its known-public | ||
| # allowlist. This replaces the in-tree copy this repo used to carry. | ||
| # | ||
| # Why the checker is not in this repo any more: the old job ran | ||
| # `scripts/check_public_repo_hygiene.py` straight out of the PR's own checkout, | ||
| # so a PR could widen the allowlist — or disable the scan — and go green. The | ||
| # reusable loads the checker from the pinned `workflows_ref` commit instead, so | ||
| # a PR here cannot reach it through this workflow's inputs. The allowlist is | ||
| # deliberately NOT an input, for the same reason. | ||
| # | ||
| # The pin is kept fresh by bump-public-repo-hygiene-callers.yml once this repo is | ||
| # enrolled in the PUBLIC_REPO_HYGIENE_CALLERS roster. | ||
| name: Public Repo Hygiene | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| hygiene: | ||
| permissions: | ||
| contents: read | ||
| uses: Comfy-Org/github-workflows/.github/workflows/public-repo-hygiene.yml@aad06972e20732d6a9167552c5b3247c4f5bac58 # github-workflows main (aad0697) | ||
| with: | ||
| # REQUIRED, and must equal the `uses:` SHA above — the reusable asserts | ||
| # they match, which is what pins the checker to the reviewed commit. | ||
| workflows_ref: aad06972e20732d6a9167552c5b3247c4f5bac58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.