Repository navigation
Tag the chart's AWS load balancers for Partner Revenue Measurement - #1030
Merged
Merged
Conversation
The load balancers this chart has AWS create now carry CopilotKit's Partner Revenue Measurement tag, aws-apn-id-058264219587 = pc:avjdxr516uh0mgsqob730tzgy, so the AWS usage OpenBot drives is credited to CopilotKit. It is the same key and value, and the same rules, as the bundled Intelligence's own Ingress. Constants in the chart, always on, no setting. - Ingress: alb.ingress.kubernetes.io/tags, rendered for every ingress class, since other controllers ignore it. - The server Service, when its type is LoadBalancer: service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags, read by the AWS Load Balancer Controller and the in-tree AWS provider. The operator's own tags are kept in order with ours appended, other partners' aws-apn-id-<account> tags and a legacy aws-apn-id carrying another partner's value are kept, a legacy aws-apn-id carrying our value is replaced by the suffixed key, and the render fails only when our key is given a different value. tests/chart-aws-attribution.test.ts renders the real chart with helm template and pins each of those on both surfaces.
davidmckayv
requested review from
MikeRyanDev,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
November 5, 2026 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The load balancers this chart has AWS create now carry CopilotKit's AWS Partner Revenue Measurement tag,
aws-apn-id-058264219587=pc:avjdxr516uh0mgsqob730tzgy. This is the same tag, with the same rules, that the bundled Intelligence already puts on its own Ingress. The key and value are constants in the chart, so the tag is always on and has no setting.alb.ingress.kubernetes.io/tags, rendered for every ingress class because other controllers ignore it. A shared Ingress group is tagged too.server.service.typeisLoadBalancer:service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags, which both the AWS Load Balancer Controller and the in-tree AWS provider read. Services of other types get no tag.How the tag merges with existing tags:
aws-apn-id-<account>tags are kept, and so is a legacyaws-apn-idthat carries another partner's value.aws-apn-idcarrying our value is replaced by the suffixed key, so nothing is counted twice.Not tagged:
There is no user-agent marker, because OpenBot has no AWS SDK. The README has a new "AWS usage attribution" section.
Testing
tests/chart-aws-attribution.test.ts(19 tests) renders the real chart withhelm templateand covers each rule above on both surfaces, including the refusal. Againstmain's templates, 17 fail. With this change, all 19 pass.bun test tests/chart-*.test.ts,biome format,biome lint --error-on-warningsandtypecheck:testsall pass, using Bun 1.4.3 and Helm 3.19.0.