fix out-of-bounds read on empty multipart boundary in message_view - #1262
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message_view::get_boundary reads to_return[0] right after slicing the Content-Type header at
boundary=, so a request whose Content-Type ends inboundary=leaves an empty string_view and the index runs out of bounds (libc++/libstdc++ hardened builds abort here). multipart::message already rejects an empty boundary with bad_request before parsing, but message_view skipped that check. This guards the index with a non-empty test and throws the same bad_request in the constructor, with a regression test mirroring the existing message case.