[DT-3313] [5/6] Add filters to the Intellectual Property and Funding Resources tabs

[kevinmarete]

Addresses

DT-3313 — 5 of 6, splitting #3926 per review. Stacked on #3936. Security risk: no.

Summary

The smallest of the asset PRs. Intellectual Property gains Type and Status alongside the Filed Date it already had; Funding Resources gains Funder Name alongside Funding Dates. Same template as #3938 and #3939: options from the full corpus, a matchAny clause, a client-side row predicate.

One thing that isn't purely additive, and is the reason to read the predicates rather than skim them: both previously ended with the date check and returned true early when the range was inactive. That was correct when the date was the tab's only filter. With a second filter on the tab, an inactive range has to fall through to the remaining checks instead of passing the row outright, so both predicates are restructured to run the date check as a block and let the array checks decide.

Mutation-checked: short-circuiting either the ipStatus or the fundingFunderName predicate fails a test.

[github-actions]

Coverage Report for DUOS Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	90.42%	12136 / 13422
🔵	Statements	89.92%	12955 / 14407
🔵	Functions	87.54%	3597 / 4109
🔵	Branches	82.96%	7640 / 9209

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/components/data_library/filterRegistry.ts	88.42%	86.15%	98.66%	87.86%	225, 303, 560-567, 730-734, 754-768, 784-793, 829-838, 847-861, 916, 952
src/components/data_library/assets/fundingResourceAsset.ts	100%	91.66%	100%	100%
src/components/data_library/assets/intellectualPropertyAsset.ts	100%	92.59%	100%	100%
src/hooks/useLibraryPageState.ts	88.07%	78.33%	82.45%	87.37%	241, 244, 256-260, 266, 303, 318, 338-342
src/hooks/useLibraryUrlState.ts	96.5%	94.68%	100%	96.29%	206, 217-219, 349
src/libs/dataLibraryFilterConfig.ts	100%	100%	100%	100%
src/types/library.ts	100%	100%	100%	100%

Generated in workflow #7261 for commit 73b7c77 by the Vitest Coverage Report Action

[Copilot]

🟢 Approval recommended

Remaining findings are minor test-coverage and documentation nits with no approval-blocking issues.

Pull request overview

Adds Type and Status filters for Intellectual Property and Funder Name filtering for Funding Resources.

Changes:

• Extends filter state, configuration, URL handling, and corpus-derived options.
• Adds Elasticsearch clauses and client-side row predicates.
• Expands component, registry, and asset tests.

File summaries

File	Description
test/components/data_library/LibraryFilters.spec.tsx	Tests new filter sections.
test/components/data_library/filterRegistry.spec.ts	Tests query clause paths.
test/components/data_library/assets/intellectualPropertyAsset.spec.ts	Tests IP filtering behavior.
test/components/data_library/assets/fundingResourceAsset.spec.ts	Tests funding filtering behavior.
src/types/library.ts	Defines new filter state and option types.
src/libs/dataLibraryFilterConfig.ts	Enables filters per asset tab.
src/hooks/useLibraryUrlState.ts	Adds URL parsing and serialization.
src/hooks/useLibraryPageState.ts	Derives full-corpus filter options.
src/components/data_library/filterRegistry.ts	Defines controls and query clauses.
src/components/data_library/assets/intellectualPropertyAsset.ts	Applies IP filtering and normalization.
src/components/data_library/assets/fundingResourceAsset.ts	Applies funding filtering and normalization.

Review details

Suppressed comments (1)

src/hooks/useLibraryPageState.ts:265

• These new option mappings are only exercised with empty arrays by the existing useLibraryPageState fixtures; the hook tests cover the analogous workspace path but never provide IP or funding buckets or assert these three option lists. A wrong response key or omission from CORPUS_DERIVED_OPTION_ASSETS would therefore leave the new panels empty while the current tests still pass. Add a focused hook test with IP and funding buckets (including an active own filter) and assert the complete option lists.

      ipType: uniqueValues(intellectualPropertyItems.map(item => item.type)),
      ipStatus: uniqueValues(intellectualPropertyItems.map(item => item.status)),
      fundingFunderName: uniqueValues(fundingResourceItems.map(item => item.funderName)),

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[fboulnois]

One suggestion:

1. New URL params have no round-trip test coverage: test/hooks/useLibraryUrlState.spec.tsx

The three new URL params (ipType, ipStatus, fundingFunderName) have no parse/serialize round-trip coverage, unlike every sibling filter added earlier in this stack.

A wrong or duplicated param string in ARRAY_FILTER_PARAM_CONFIG type-checks fine (only key is typed) and would silently clobber another filter's query param on share/restore.

Fix: add round-trip cases for the three new params, matching the existing sibling coverage.

[kevinmarete]

Fixed in 19170c5c, thanks.

Added parse/serialize/clear cases for ipType, ipStatus and fundingFunderName, matching the sibling coverage.

Also added a pass for the collision specifically: no per-key test can catch a duplicated param, since each key still round-trips fine in isolation while quietly clobbering its sibling. That one writes every array filter at once and reads them all back. Pointing fundingFunderName at ipType's param fails it; a plain typo fails the per-key cases.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.7% Duplication on New Code

See analysis details on SonarQube Cloud

[otchet-broad]

👍