feat(pipeline): Ensemble production topology routing pass for ObjectScript/IRIS#1063
Open
isc-tdyar wants to merge 1 commit into
Open
feat(pipeline): Ensemble production topology routing pass for ObjectScript/IRIS#1063isc-tdyar wants to merge 1 commit into
isc-tdyar wants to merge 1 commit into
Conversation
Adds pass_ensemble_routing.c, a pre-dump pipeline pass that reads
Ensemble production definitions (XData ProductionDefinition blocks)
and emits ROUTES_TO edges between production items.
The pass:
- Early-exits when no ObjectScript source files (.cls/.mac/.int)
are present in the graph buffer, making it zero-cost on non-IRIS
projects.
- Parses <Item> / <Setting> XML from each XData ProductionDefinition
found in the graph buffer.
- Emits EnsembleItem nodes and ROUTES_TO edges with confidence scores
(0.95 for literal target names, 0.85 for property-resolved names).
- Logs a cbm_log_warn when MAX_ITEMS (256) or MAX_SETTINGS (8) caps
truncate the parsed production.
Signed-off-by: Thomas Dyar <tdyar@intersystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
pass_ensemble_routing— a pipeline pass that statically extracts InterSystems Ensemble/IRIS Interoperability production topology from ObjectScript.clsfiles at index time. No live IRIS instance required.Closes #1061. Follows up on #467 (ObjectScript language support) — split out at reviewer request.
What it does
Pass A — EnsembleItem nodes: reads each
EnsembleProductionclass'sProductionDefinitionXData block (XML), parses<Item Name="..." ClassName="...">entries, and createsEnsembleItemnodes for each production component (business services, processes, operations).Pass B — ROUTES_TO edges: for each
EnsembleItem, reads the source.clsfile and extracts routing rules referencing other components by class name, emittingROUTES_TOedges. Uses segment-anchored matching (qn_ends_with_segment) to avoid false positives from partial class name matches.WorkMgr dispatch: detects
.Queue("##class(X).method", ...)calls and emitsCALLSedges to the target method — the same static dispatch pattern as task queues in Celery/Airflow.Changes from the version reviewed in #467
Per review feedback:
cbm_log_warnfires whenMAX_ITEMSorMAX_SETTINGScaps are hit so silent truncation is visible in logsFiles changed
src/pipeline/pass_ensemble_routing.{c,h}— new passsrc/pipeline/pipeline.c— wired intorun_predump_passesMakefile.cbm— added to SRCS