T1329677 DataGrid - Column width changes are not applied immediately#34325
Draft
nightskylark wants to merge 4 commits into
Draft
T1329677 DataGrid - Column width changes are not applied immediately#34325nightskylark wants to merge 4 commits into
nightskylark wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a DataGrid sizing/resizing issue where column width updates may not be applied immediately by refactoring parts of the grid’s column synchronization flow (best-fit toggling, max-width handling) and tightening selection-range handling used during temporary layout measurement. It also includes a small TypeScript-typing workaround in the Popover escape-key handler.
Changes:
- Refactors
ResizingController._synchronizeColumnsto use a temporary best-fit enable/restore helper, normalize group expand column widths, and centralize max-width set/clear logic. - Introduces a typed
SelectionRangecontract and updates selection-range getters/setters to use explicit sentinel values. - Adjusts Popover overlay-stack comparison typing to avoid a TypeScript “no overlap” error.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/popover/popover.ts | Tweaks overlay stack top-check typing in ESC key handler. |
| packages/devextreme/js/__internal/grids/grid_core/views/m_grid_view.ts | Refactors grid column synchronization/best-fit/maxWidth handling related to resizing. |
| packages/devextreme/js/__internal/grids/grid_core/m_utils.ts | Adds SelectionRange type and makes selection-range APIs more explicit/typed. |
| } | ||
| return undefined; | ||
| }); | ||
| private _synchronizeColumns():void { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.