Dataclasses - #39
Merged
Merged
Dataclasses#39
Conversation
only motor_responses are parsed into the nested dataclass still need to parse the other statuses in
bring across changes from comms_qtthread to original comms_thread file
remove now duplicate file
bring across changes from comms_qtthread_2 to original comms_thread file and now use the original file in program
remove now duplicate file
needs to be picked apart later as some code may still be needed (ie. watches)
construct the controller status at the end when you have all the statuses (bools)
JamesOHeaDLS
requested changes
Sep 11, 2026
JamesOHeaDLS
left a comment
JamesOHeaDLS
left a comment
Contributor
There was a problem hiding this comment.
Thanks @M-Chan - these changes are all good, I've just suggested a couple of refinements.
With these changes to comms_thread.py and status_dataclasses.py, main.py should now be revisited to work with this new structure
JamesOHeaDLS
approved these changes
Sep 17, 2026
JamesOHeaDLS
left a comment
JamesOHeaDLS
left a comment
Contributor
There was a problem hiding this comment.
Cool! Looks good, thanks @M-Chan
I have made one note for the deletion of a line of commented code, but otherwise it is ready for a squash merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dataclasses for polling status